Skip to content

[React] expose useUpdateNFTMetadata hook #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 1, 2024

Problem solved

Short description of the bug fixed or feature added

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:


PR-Codex overview

The focus of this PR is to introduce a new hook useUpdateNFTMetadata in the react-core package for updating NFT metadata.

Detailed summary

  • Added useUpdateNFTMetadata hook in react-core
  • Updated update method to updateMetadata in erc-721.ts
  • Added alias for update method for backward compatibility
  • Imported types and made adjustments in nft.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joaquim-verges joaquim-verges requested a review from a team as a code owner March 1, 2024 21:42
@joaquim-verges joaquim-verges requested a review from a team March 1, 2024 21:42
Copy link

changeset-bot bot commented Mar 1, 2024

🦋 Changeset detected

Latest commit: 415a01f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/react-core Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
thirdweb Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges
Copy link
Member Author

/release-pr

@joaquim-verges
Copy link
Member Author

/release-pr

@joaquim-verges
Copy link
Member Author

/release-pr

@joaquim-verges
Copy link
Member Author

/release-pr

@joaquim-verges joaquim-verges enabled auto-merge March 4, 2024 19:40
@joaquim-verges joaquim-verges added this pull request to the merge queue Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.96%. Comparing base (5a648f7) to head (415a01f).
Report is 2 commits behind head on main.

Files Patch % Lines
packages/sdk/src/evm/core/classes/erc-721.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
+ Coverage   66.92%   66.96%   +0.03%     
==========================================
  Files         293      293              
  Lines       11250    11236      -14     
  Branches     1564     1557       -7     
==========================================
- Hits         7529     7524       -5     
+ Misses       3085     3079       -6     
+ Partials      636      633       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 7d8697e Mar 4, 2024
@joaquim-verges joaquim-verges deleted the joaquim/update-metadata-hoook branch March 4, 2024 19:45
@jnsdls jnsdls mentioned this pull request Mar 4, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* chore: copy changes

* chore: update copy

* Update components/pay/PayConfig.tsx

Co-authored-by: Nacho Iacovino <50103937+nachoiacovino@users.noreply.github.com>
Signed-off-by: Winston Yeo <44563205+ElasticBottle@users.noreply.github.com>

---------

Signed-off-by: Winston Yeo <44563205+ElasticBottle@users.noreply.github.com>
Co-authored-by: Nacho Iacovino <50103937+nachoiacovino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant