Skip to content

[SDK] update NFT drop metadata #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2024
Merged

[SDK] update NFT drop metadata #2404

merged 3 commits into from
Mar 6, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 5, 2024

Problem solved

Short description of the bug fixed or feature added

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:


PR-Codex overview

The focus of this PR is to update metadata handling for DropERC721 contracts in the SDK.

Detailed summary

  • Added NFTMetadataInput for metadata updates
  • Updated metadata handling in ERC721 classes
  • Improved batch processing for metadata updates

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joaquim-verges joaquim-verges requested a review from a team March 5, 2024 23:32
Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: cd3d745

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges enabled auto-merge March 5, 2024 23:32
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.02%. Comparing base (5f243bb) to head (cd3d745).
Report is 2 commits behind head on main.

Files Patch % Lines
...e/classes/internal/erc721/erc-721-lazy-mintable.ts 90.00% 1 Missing and 2 partials ⚠️
packages/sdk/src/evm/core/classes/erc-721.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2404      +/-   ##
==========================================
+ Coverage   66.96%   67.02%   +0.06%     
==========================================
  Files         293      293              
  Lines       11236    11267      +31     
  Branches     1557     1562       +5     
==========================================
+ Hits         7524     7552      +28     
  Misses       3079     3079              
- Partials      633      636       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquim-verges joaquim-verges added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 9c7fbc1 Mar 6, 2024
@joaquim-verges joaquim-verges deleted the joaquim/nft_drop_meta branch March 6, 2024 04:45
@jnsdls jnsdls mentioned this pull request Mar 6, 2024
jnsdls added a commit that referenced this pull request Jun 19, 2024
* WIP v5 snippets

* cleanup

* chore: Update dependencies and remove unnecessary imports

* Update core-ui/update-notice/update-notice.tsx

Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>

* update

* fix: Handle null chain value in DeprecatedAlert component

* temp add resolveMethod for now

* checkly not happy

* types cleanup

* remove deprecated alert

* lint

* re-add banner

---------

Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>
Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant