Skip to content

smart wallet autoconnect and other fixes #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 28, 2024

PR-Codex overview

The focus of this PR is to introduce legacy support for hotlink scripts and enhance wallet connection functionality in the application.

Detailed summary

  • Legacy support added for hotlink scripts
  • Improved wallet connection logic with account abstraction feature
  • New functions added for saving and retrieving connection parameters from storage

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@MananTank MananTank requested a review from a team March 28, 2024 09:32
Copy link

changeset-bot bot commented Mar 28, 2024

⚠️ No Changeset found

Latest commit: cc2a88d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank
Copy link
Member Author

  • support smart wallet autoconnect when using ConnectButton
  • This is a workaround for now - add support for smart wallet autoconnect outside connectButton later

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 13.11%. Comparing base (01fd523) to head (cc2a88d).
Report is 5 commits behind head on main.

Files Patch % Lines
...src/react/core/hooks/connection/useAutoConnect.tsx 0.00% 79 Missing ⚠️
...eb/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx 0.00% 6 Missing ⚠️
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx 0.00% 3 Missing ⚠️
...b/src/react/web/ui/ConnectWallet/ConnectWallet.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2558      +/-   ##
==========================================
- Coverage   18.23%   13.11%   -5.13%     
==========================================
  Files        1944     1651     -293     
  Lines      111607   100364   -11243     
  Branches     2253      705    -1548     
==========================================
- Hits        20354    13160    -7194     
+ Misses      90602    87187    -3415     
+ Partials      651       17     -634     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Mar 28, 2024

CodSpeed Performance Report

Merging #2558 will not alter performance

Comparing mnn/var-wallet-improvements (cc2a88d) with main (6d7eedc)

Summary

✅ 9 untouched benchmarks

@MananTank MananTank added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 889a1a0 Mar 28, 2024
@MananTank MananTank deleted the mnn/var-wallet-improvements branch March 28, 2024 09:52
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* Initial Commit

* Prettier fixes

* Adding Haun and Monad

* Adding more partners

* Adding engine and growth FAQ

* Prettier fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant