Skip to content

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 1, 2024

  • expose signTransaction for embeddedWallet (user request)

PR-Codex overview

This PR focuses on adding ERC4337 extensions to the thirdweb package. It introduces new functions and types related to account permissions and transactions.

Detailed summary

  • Added ERC4337 extensions
  • New functions for date manipulation
  • Implemented UUID generation
  • Updated transaction handling in various files
  • Added functions for managing admin and session key permissions

The following files were skipped due to too many changes: packages/thirdweb/src/extensions/erc4337/account/addSessionKey.ts, packages/thirdweb/src/extensions/erc721/write/sigMint.ts, packages/thirdweb/src/extensions/erc4337/account/common.ts, packages/thirdweb/src/exports/extensions/erc4337.ts, packages/thirdweb/src/extensions/erc4337/account/permissions.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joaquim-verges joaquim-verges requested a review from a team April 1, 2024 13:36
Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: 5f630e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Apr 1, 2024

CodSpeed Performance Report

Merging #2606 will not alter performance

Comparing joaquim/session_keys (5f630e2) with main (7234e6b)

Summary

✅ 9 untouched benchmarks

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.83%. Comparing base (3aaad1e) to head (4a32a0c).
Report is 5 commits behind head on main.

❗ Current head 4a32a0c differs from pull request most recent head 5f630e2. Consider uploading reports for the commit 5f630e2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2606       +/-   ##
===========================================
+ Coverage   13.15%   65.83%   +52.68%     
===========================================
  Files        1660      293     -1367     
  Lines      101135    10875    -90260     
  Branches      706     1570      +864     
===========================================
- Hits        13303     7160     -6143     
+ Misses      87815     3079    -84736     
- Partials       17      636      +619     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the failing test

@jnsdls jnsdls enabled auto-merge April 2, 2024 01:35
@jnsdls jnsdls added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 0394eb2 Apr 2, 2024
@jnsdls jnsdls deleted the joaquim/session_keys branch April 2, 2024 01:42
@jnsdls jnsdls mentioned this pull request Apr 2, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* Fix: Ngrok update for Engine Dashboard Explorer

* updated header for engine instance api calls

* Added a warning/alert on Engine Import

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants