refactor: separate onConnectRequested impl between web and native

[joaquim-verges]

PR-Codex overview

The focus of this PR is to update references from coinbaseSDKWallet to coinbaseWebSDK for improved consistency and functionality.

Detailed summary

• Updated file imports and type exports to reference coinbaseWebSDK instead of coinbaseSDKWallet
• Added showCoinbasePopup function in coinbaseWebSDK
• Updated function imports and references in various files for coinbaseWebSDK

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 0:37am

[changeset-bot]

⚠️ No Changeset found

Latest commit: eca6217

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[graphite-app]

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[joaquim-verges]

• refactor: separate onConnectRequested impl between web and native #3344 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3344 will not alter performance

_{Comparing refactor/update-coinbase-imports (eca6217) with main (df84f9c)}

Summary

✅ 9 untouched benchmarks

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.59 KB (0%)	812 ms (0%)	418 ms (+4.28% 🔺)	1.3 s
thirdweb (cjs)	90.32 KB (0%)	1.9 s (0%)	951 ms (-4.42% 🔽)	2.8 s
thirdweb (minimal + tree-shaking)	4.75 KB (0%)	95 ms (0%)	56 ms (+101.99% 🔺)	151 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	12 ms (-30.38% 🔽)	22 ms
thirdweb/react (minimal + tree-shaking)	13.47 KB (0%)	270 ms (0%)	48 ms (-21% 🔽)	317 ms

[codecov]

Codecov Report

Attention: Patch coverage is 34.37500% with 21 lines in your changes missing coverage. Please review.

Project coverage is 62.76%. Comparing base (df84f9c) to head (eca6217).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3344      +/-   ##
==========================================
- Coverage   62.81%   62.76%   -0.05%     
==========================================
  Files         859      861       +2     
  Lines       63693    63771      +78     
  Branches     3443     3443              
==========================================
+ Hits        40008    40026      +18     
- Misses      23010    23070      +60     
  Partials      675      675              

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.60% <ø> (ø)		Carriedforward from df84f9c
packages	62.17% <34.37%> (-0.06%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...b/src/react/web/utils/usePreloadWalletProviders.ts	75.51% <100.00%> (ø)
...es/thirdweb/src/wallets/coinbase/coinbaseWebSDK.ts	36.27% <100.00%> (ø)
...s/thirdweb/src/wallets/eip5792/get-calls-status.ts	89.01% <50.00%> (ø)
...s/thirdweb/src/wallets/eip5792/get-capabilities.ts	87.09% <50.00%> (ø)
...ackages/thirdweb/src/wallets/eip5792/send-calls.ts	92.41% <50.00%> (ø)
.../thirdweb/src/wallets/eip5792/show-calls-status.ts	88.15% <50.00%> (ø)
packages/thirdweb/src/wallets/coinbase/utils.ts	33.33% <33.33%> (ø)
...s/thirdweb/src/wallets/coinbase/coinbase-wallet.ts	48.67% <14.28%> (+3.29%)	⬆️
packages/thirdweb/src/wallets/create-wallet.ts	44.37% <22.22%> (-0.85%)	⬇️

... and 1 file with indirect coverage changes

[graphite-app]

Merge activity

• Jun 16, 8:35 PM EDT: joaquim-verges added this pull request to the Graphite merge queue.
• Jun 16, 8:38 PM EDT: joaquim-verges merged this pull request with the Graphite merge queue.