[Refactor] Remove unused ConnectUIContext and refactor wallet connection components #3449

jnsdls · 2024-06-21T23:04:49Z

This pull request aims to clean up the codebase by removing unused packages and files. The following tasks were carried out:

What changed?

Deleted the useWalletConnectionCtx.ts file from the thirdweb package.
Deleted the wallet-connection.tsx file from the thirdweb package.
Updated ConnectButton.tsx, AllWalletsUI.tsx, AnyWalletConnectUI.tsx, ConnectEmbed.tsx, and other UI components to remove references to the deleted files.
Modified various other files in the thirdweb and react packages to ensure that no part of the codebase relies on the removed files.

How to test?

Run the project and navigate through the UI to ensure that the wallet connection features are functioning as expected without any errors.
Check the console for any warnings or errors related to missing files or dependencies.

Why make this change?

Removing unused packages and files helps to streamline the codebase, improving maintainability, and potentially reducing build times. This cleanup is part of ongoing efforts to ensure the codebase remains clean and efficient.

PR-Codex overview

This PR refactors context usage in the connect wallet UI, updates in-app wallet locale handling, and optimizes code structure.

Detailed summary

Refactored context usage in connect wallet UI
Updated in-app wallet locale handling
Optimized code structure

The following files were skipped due to too many changes: packages/thirdweb/src/react/web/wallets/shared/GetStartedScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/InjectedConnectUI.tsx, packages/thirdweb/src/react/web/wallets/shared/CoinbaseSDKConnection.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButton.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/WalletEntryButton.tsx, packages/thirdweb/src/react/web/wallets/in-app/InAppWalletSelectionUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx, packages/thirdweb/src/react/web/wallets/ecosystem/EcosystemWalletConnectUI.tsx, packages/thirdweb/src/react/web/wallets/shared/SocialLogin.tsx, packages/thirdweb/src/react/web/wallets/in-app/InAppWalletConnectUI.tsx, packages/thirdweb/src/react/web/wallets/ecosystem/EcosystemWalletFormUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/StartScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectModal.tsx, packages/thirdweb/src/react/web/wallets/shared/ConnectWalletSocialOptions.tsx, packages/thirdweb/src/react/web/wallets/shared/OTPLoginUI.tsx, packages/thirdweb/src/react/web/wallets/in-app/InAppWalletFormUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectModalInline.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AnyWalletConnectUI.tsx, packages/thirdweb/src/react/web/wallets/shared/WalletConnectConnection.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectModalContent.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-06-21T23:04:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2024 0:09am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 23, 2024 0:09am

changeset-bot · 2024-06-21T23:04:53Z

🦋 Changeset detected

Latest commit: eaa5093

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/sdk	Patch
@thirdweb-dev/cli	Patch
@thirdweb-dev/react-core	Patch
@thirdweb-dev/react	Patch
@thirdweb-dev/unity-js-bridge	Patch
@thirdweb-dev/wallets	Patch
@thirdweb-dev/auth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2024-06-21T23:04:54Z

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

jnsdls · 2024-06-21T23:05:03Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite

codspeed-hq · 2024-06-21T23:08:07Z

CodSpeed Performance Report

Merging #3449 will not alter performance

_{Comparing refactor/remove-unused-context (eaa5093) with main (e743489)}

Summary

✅ 9 untouched benchmarks

github-actions · 2024-06-21T23:09:05Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.63 KB (0%)	813 ms (0%)	911 ms (-2.7% 🔽)	1.8 s
thirdweb (cjs)	91.84 KB (0%)	1.9 s (0%)	1.9 s (+12.26% 🔺)	3.7 s
thirdweb (minimal + tree-shaking)	4.79 KB (0%)	96 ms (0%)	32 ms (-15.62% 🔽)	128 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	26 ms (+54.55% 🔺)	36 ms
thirdweb/react (minimal + tree-shaking)	13.49 KB (0%)	270 ms (0%)	131 ms (+38.53% 🔺)	401 ms

codecov · 2024-06-21T23:12:07Z

Codecov Report

Attention: Patch coverage is 35.49433% with 398 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (e743489) to head (eaa5093).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
- Coverage   61.14%   61.01%   -0.14%     
==========================================
  Files         891      889       -2     
  Lines       67375    67693     +318     
  Branches     3498     3498              
==========================================
+ Hits        41196    41301     +105     
- Misses      25496    25709     +213     
  Partials      683      683

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.60% <ø> (ø)`		Carriedforward from e743489
packages	`60.13% <35.49%> (-0.16%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
.../react/web/ui/ConnectWallet/Modal/ConnectModal.tsx	`85.33% <100.00%> (+5.89%)`	⬆️
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx	`57.70% <95.45%> (-0.82%)`	⬇️
...t/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx	`36.47% <33.33%> (+0.83%)`	⬆️
...rdweb/src/react/web/ui/ConnectWallet/Modal/TOS.tsx	`16.94% <33.33%> (ø)`
...eb/src/react/web/ui/ConnectWallet/Modal/screen.tsx	`78.04% <83.33%> (+0.83%)`	⬆️
...t/web/ui/ConnectWallet/screens/SignatureScreen.tsx	`15.80% <0.00%> (-0.26%)`	⬇️
...eact/web/wallets/shared/locale/getConnectLocale.ts	`30.00% <33.33%> (ø)`
.../src/react/web/wallets/shared/GetStartedScreen.tsx	`23.40% <57.14%> (+0.55%)`	⬆️
.../src/react/web/wallets/shared/ConnectingScreen.tsx	`28.69% <60.00%> (+3.24%)`	⬆️
...c/react/web/wallets/in-app/useInAppWalletLocale.ts	`39.13% <40.00%> (-5.87%)`	⬇️
... and 14 more

... and 2 files with indirect coverage changes

joaquim-verges

very nice, more in line with my react native impl too.

one thing i want to do in both react native and react is export every single one of our 'screens' and useful components we use in there. This will help a lot.

ex. SendFunds - ReceiveFunds - ViewFunds should all be exported, embeddable components. So we need to make sure the inputs to these components make sense to be used standalone

graphite-app · 2024-06-23T00:04:31Z

Merge activity

Jun 22, 8:04 PM EDT: jnsdls added this pull request to the Graphite merge queue.
Jun 22, 8:11 PM EDT: jnsdls merged this pull request with the Graphite merge queue.

…ion components (#3449) This pull request aims to clean up the codebase by removing unused packages and files. The following tasks were carried out: ### What changed? 1. Deleted the `useWalletConnectionCtx.ts` file from the `thirdweb` package. 2. Deleted the `wallet-connection.tsx` file from the `thirdweb` package. 3. Updated `ConnectButton.tsx`, `AllWalletsUI.tsx`, `AnyWalletConnectUI.tsx`, `ConnectEmbed.tsx`, and other UI components to remove references to the deleted files. 4. Modified various other files in the `thirdweb` and `react` packages to ensure that no part of the codebase relies on the removed files. ### How to test? 1. Run the project and navigate through the UI to ensure that the wallet connection features are functioning as expected without any errors. 2. Check the console for any warnings or errors related to missing files or dependencies. ### Why make this change? Removing unused packages and files helps to streamline the codebase, improving maintainability, and potentially reducing build times. This cleanup is part of ongoing efforts to ensure the codebase remains clean and efficient. ---  --- ## PR-Codex overview This PR refactors context usage in the connect wallet UI and updates locale types for in-app wallets. ### Detailed summary - Refactored context usage in connect wallet UI - Updated locale types for in-app wallets - Renamed functions for better clarity > The following files were skipped due to too many changes: `packages/thirdweb/src/react/web/wallets/shared/GetStartedScreen.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/InjectedConnectUI.tsx`, `packages/thirdweb/src/react/web/wallets/shared/CoinbaseSDKConnection.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/useConnectModal.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButton.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/WalletEntryButton.tsx`, `packages/thirdweb/src/react/web/wallets/in-app/InAppWalletSelectionUI.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AllWalletsUI.tsx`, `packages/thirdweb/src/react/web/wallets/ecosystem/EcosystemWalletConnectUI.tsx`, `packages/thirdweb/src/react/web/wallets/shared/SocialLogin.tsx`, `packages/thirdweb/src/react/web/wallets/in-app/InAppWalletConnectUI.tsx`, `packages/thirdweb/src/react/web/wallets/ecosystem/EcosystemWalletFormUI.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/StartScreen.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectModal.tsx`, `packages/thirdweb/src/react/web/wallets/shared/ConnectWalletSocialOptions.tsx`, `packages/thirdweb/src/react/web/wallets/shared/OTPLoginUI.tsx`, `packages/thirdweb/src/react/web/wallets/in-app/InAppWalletFormUI.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectModalInline.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AnyWalletConnectUI.tsx`, `packages/thirdweb/src/react/web/wallets/shared/WalletConnectConnection.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectModalContent.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

jnsdls marked this pull request as ready for review June 21, 2024 23:05

github-actions bot added the TS SDK Involves changes to the v5 TypeScript SDK. label Jun 21, 2024

jnsdls requested a review from MananTank as a code owner June 21, 2024 23:05

jnsdls requested review from gregfromstl and joaquim-verges June 21, 2024 23:05

vercel bot deployed to Preview – thirdweb_playground June 21, 2024 23:08 View deployment

vercel bot deployed to Preview – thirdweb-www June 21, 2024 23:18 View deployment

joaquim-verges reviewed Jun 22, 2024

View reviewed changes

joaquim-verges approved these changes Jun 22, 2024

View reviewed changes

jnsdls mentioned this pull request Jun 22, 2024

[Refactor] Simplify ConnectModal properties and related components #3453

Merged

jnsdls force-pushed the refactor/remove-unused-context branch from 7606df5 to 8629634 Compare June 22, 2024 19:08

vercel bot deployed to Preview – thirdweb_playground June 22, 2024 19:13 View deployment

vercel bot deployed to Preview – thirdweb-www June 22, 2024 19:21 View deployment

jnsdls force-pushed the refactor/remove-unused-context branch from 8629634 to c6ce8c3 Compare June 23, 2024 00:00

vercel bot deployed to Preview – thirdweb_playground June 23, 2024 00:02 View deployment

vercel bot deployed to Preview – thirdweb-www June 23, 2024 00:04 View deployment

jnsdls force-pushed the refactor/remove-unused-context branch from c6ce8c3 to eaa5093 Compare June 23, 2024 00:05

vercel bot deployed to Preview – thirdweb_playground June 23, 2024 00:07 View deployment

vercel bot deployed to Preview – thirdweb-www June 23, 2024 00:09 View deployment

graphite-app bot merged commit eaa5093 into main Jun 23, 2024
30 of 31 checks passed

graphite-app bot deleted the refactor/remove-unused-context branch June 23, 2024 00:11

vercel bot temporarily deployed to Production – thirdweb_playground June 23, 2024 00:15 Inactive

jnsdls mentioned this pull request Jun 23, 2024

Version Packages #3426

Merged

vercel bot deployed to Production – thirdweb-www June 23, 2024 00:22 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Refactor] Remove unused ConnectUIContext and refactor wallet connection components #3449

[Refactor] Remove unused ConnectUIContext and refactor wallet connection components #3449

Uh oh!

jnsdls commented Jun 21, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Jun 21, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Jun 21, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 21, 2024

Uh oh!

jnsdls commented Jun 21, 2024 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jun 21, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jun 21, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jun 21, 2024 •

edited

Loading

Uh oh!

joaquim-verges left a comment

Uh oh!

graphite-app bot commented Jun 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

[Refactor] Remove unused ConnectUIContext and refactor wallet connection components #3449

[Refactor] Remove unused ConnectUIContext and refactor wallet connection components #3449

Uh oh!

Conversation

jnsdls commented Jun 21, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

How to test?

Why make this change?

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

graphite-app bot commented Jun 21, 2024

Your org requires the Graphite merge queue for merging into main

Uh oh!

jnsdls commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #3449 will not alter performance

Summary

Uh oh!

github-actions bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joaquim-verges left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Jun 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

jnsdls commented Jun 21, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Jun 21, 2024 •

edited

Loading

changeset-bot bot commented Jun 21, 2024 •

edited

Loading

jnsdls commented Jun 21, 2024 •

edited

Loading

codspeed-hq bot commented Jun 21, 2024 •

edited

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

codecov bot commented Jun 21, 2024 •

edited

Loading

graphite-app bot commented Jun 23, 2024 •

edited

Loading