Skip to content

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 29, 2024

This pull request updates package.json dependencies to specific versions across multiple packages, moving from using caret (^) to specific version numbers for consistency and to prevent unwanted updates. Additionally, it includes changes to various TypeScript files, primarily adding the ESLint directive @typescript-eslint/no-unused-vars to suppress warnings for unused variables.



PR-Codex overview

This PR updates dependencies, adds styled components, and disables eslint rules.

Detailed summary

  • Updated dependencies
  • Added styled components for various UI elements
  • Disabled eslint rules for unused variables

The following files were skipped due to too many changes: apps/playground-web/src/components/blockchain-api/write-contract-extension.tsx, legacy_packages/react/src/wallet/ConnectWallet/NetworkSelector.tsx, apps/playground-web/package.json, legacy_packages/react/package.json, apps/playground-web/src/components/blockchain-api/write-contract-raw.tsx, package.json, apps/dashboard/package.json, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 0:10am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 0:10am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 0:10am

Copy link

changeset-bot bot commented Jun 29, 2024

🦋 Changeset detected

Latest commit: cbb0bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
eslint-config-thirdweb Patch
@thirdweb-dev/service-utils Patch
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

graphite-app bot commented Jun 29, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls marked this pull request as ready for review June 29, 2024 18:02
Copy link
Member Author

jnsdls commented Jun 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. TS SDK Involves changes to the v5 TypeScript SDK. labels Jun 29, 2024
Copy link

codspeed-hq bot commented Jun 29, 2024

CodSpeed Performance Report

Merging #3554 will improve performances by 13.14%

Comparing fix/package-changes (cbb0bc2) with main (80b9cd9)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark main fix/package-changes Change
keccakId 1.5 ms 1.3 ms +13.14%

Copy link
Contributor

github-actions bot commented Jun 29, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.47 KB (0%) 810 ms (0%) 2.3 s (-67.38% 🔽) 3.1 s
thirdweb (cjs) 89.99 KB (0%) 1.8 s (0%) 8 s (+14.49% 🔺) 9.8 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 382 ms (+69.24% 🔺) 477 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 155 ms (+17.21% 🔺) 165 ms
thirdweb/react (minimal + tree-shaking) 13.52 KB (0%) 271 ms (0%) 485 ms (-58.18% 🔽) 755 ms

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.69%. Comparing base (80b9cd9) to head (cbb0bc2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3554      +/-   ##
==========================================
+ Coverage   62.49%   62.69%   +0.20%     
==========================================
  Files         899      898       -1     
  Lines       68843    68570     -273     
  Branches     3670     3670              
==========================================
- Hits        43024    42992      -32     
+ Misses      25131    24890     -241     
  Partials      688      688              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.59% <ø> (ø) Carriedforward from 80b9cd9
packages 62.15% <ø> (+0.23%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

graphite-app bot commented Jun 30, 2024

Merge activity

This pull request updates package.json dependencies to specific versions across multiple packages, moving from using caret (^) to specific version numbers for consistency and to prevent unwanted updates. Additionally, it includes changes to various TypeScript files, primarily adding the ESLint directive `@typescript-eslint/no-unused-vars` to suppress warnings for unused variables.

---

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates dependencies, adds styled components, and disables eslint for unused vars in various React components.

### Detailed summary
- Updated dependencies in multiple package.json files
- Added styled components for DialogContent, Overlay, DropContainer, QRPlaceholder, and more
- Disabled eslint for unused vars in React components
- Updated next.config.mjs in playground-web
- Updated pnpm-workspace.yaml
- Added eslint and styled components in wallets package.json
- Updated dependencies in wallet-ui package.json

> The following files were skipped due to too many changes: `apps/playground-web/src/components/blockchain-api/write-contract-extension.tsx`, `legacy_packages/react/src/wallet/ConnectWallet/NetworkSelector.tsx`, `apps/playground-web/package.json`, `legacy_packages/react/package.json`, `apps/playground-web/src/components/blockchain-api/write-contract-raw.tsx`, `package.json`, `apps/dashboard/package.json`, `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. TS SDK Involves changes to the v5 TypeScript SDK.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants