fix(thirdweb): add optional 'from' in readContract method #3735

joaquim-verges · 2024-07-18T00:00:41Z

PR-Codex overview

The focus of this PR is to enhance the blockchain API functionalities by adding an optional 'from' parameter in readContract() and adjusting block wait times.

Detailed summary

Added optional 'from' parameter in readContract()
Adjusted block wait times to 10 blocks in multiple files
Updated default max blocks wait time to 100
Modified useReadContract function parameters for improved functionality

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-07-18T00:00:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2024 8:11am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2024 8:11am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2024 8:11am

changeset-bot · 2024-07-18T00:00:45Z

🦋 Changeset detected

Latest commit: 6cc3038

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
thirdweb	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2024-07-18T00:00:48Z

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

joaquim-verges · 2024-07-18T00:00:57Z

fix(thirdweb): add optional 'from' in readContract method #3735 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite

codspeed-hq · 2024-07-18T00:03:28Z

CodSpeed Performance Report

Merging #3735 will not alter performance

_{Comparing fix-thirdweb-update-readcontract-options (6cc3038) with main (db2cadf)}

Summary

✅ 9 untouched benchmarks

github-actions · 2024-07-18T00:04:40Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43.16 KB (+0.1% 🔺)	864 ms (+0.1% 🔺)	940 ms (+14.45% 🔺)	1.9 s
thirdweb (cjs)	91.17 KB (-0.19% 🔽)	1.9 s (-0.19% 🔽)	1.5 s (-14.23% 🔽)	3.3 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	240 ms (+309.66% 🔺)	337 ms
thirdweb/chains (tree-shaking)	433 B (0%)	10 ms (0%)	121 ms (+302.31% 🔺)	131 ms
thirdweb/react (minimal + tree-shaking)	13.52 KB (+0.02% 🔺)	271 ms (+0.02% 🔺)	180 ms (+157.54% 🔺)	450 ms

jnsdls

Broken test to fix otherwise looks good. Seems like the test is broken due do not relying on the default block wait time const only.

codecov · 2024-07-18T07:44:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.51%. Comparing base (db2cadf) to head (6cc3038).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3735   +/-   ##
=======================================
  Coverage   61.51%   61.51%           
=======================================
  Files         926      926           
  Lines       73136    73138    +2     
  Branches     3716     3717    +1     
=======================================
+ Hits        44987    44989    +2     
  Misses      27465    27465           
  Partials      684      684

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.66% <ø> (ø)`		Carriedforward from db2cadf
packages	`60.78% <100.00%> (+<0.01%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...web/src/transaction/actions/wait-for-tx-receipt.ts	`93.06% <100.00%> (ø)`
packages/thirdweb/src/transaction/read-contract.ts	`88.46% <100.00%> (+0.12%)`	⬆️
...es/thirdweb/src/wallets/eip5792/wait-for-bundle.ts	`95.91% <100.00%> (ø)`

graphite-app · 2024-07-18T07:54:15Z

Merge activity

Jul 18, 3:54 AM EDT: joaquim-verges added this pull request to the Graphite merge queue.
Jul 18, 4:12 AM EDT: joaquim-verges merged this pull request with the Graphite merge queue.

Fixes #3683  --- ## PR-Codex overview The focus of this PR is to add an optional 'from' parameter in the `readContract()` function and update default max block wait times to 100 in various files. ### Detailed summary - Added optional 'from' parameter in `readContract()` - Updated default max block wait times to 10 in specific files - Increased default max block wait times to 100 in other files > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

github-actions bot added the TS SDK Involves changes to the v5 TypeScript SDK. label Jul 18, 2024

joaquim-verges requested review from gregfromstl, jnsdls and MananTank July 18, 2024 00:01

joaquim-verges marked this pull request as ready for review July 18, 2024 00:01

vercel bot deployed to Preview – wallet-ui July 18, 2024 00:05 View deployment

vercel bot deployed to Preview – thirdweb_playground July 18, 2024 00:05 View deployment

joaquim-verges force-pushed the fix-thirdweb-update-readcontract-options branch from 5036aa2 to 91abf16 Compare July 18, 2024 00:11

github-actions bot added the Playground Changes involving the Playground codebase. label Jul 18, 2024

joaquim-verges mentioned this pull request Jul 18, 2024

Override "from" on useReadContract #3683

Closed

joaquim-verges force-pushed the fix-thirdweb-update-readcontract-options branch from 91abf16 to 32a08e3 Compare July 18, 2024 00:22

vercel bot deployed to Preview – wallet-ui July 18, 2024 00:25 View deployment

vercel bot deployed to Preview – thirdweb_playground July 18, 2024 00:27 View deployment

vercel bot deployed to Preview – thirdweb-www July 18, 2024 00:38 View deployment

joaquim-verges force-pushed the fix-thirdweb-update-readcontract-options branch from 32a08e3 to b7a351d Compare July 18, 2024 02:00

vercel bot deployed to Preview – wallet-ui July 18, 2024 02:02 View deployment

vercel bot deployed to Preview – thirdweb_playground July 18, 2024 02:03 View deployment

vercel bot deployed to Preview – thirdweb-www July 18, 2024 02:14 View deployment

jnsdls approved these changes Jul 18, 2024

View reviewed changes

joaquim-verges force-pushed the fix-thirdweb-update-readcontract-options branch from b7a351d to 5462554 Compare July 18, 2024 07:37

vercel bot deployed to Preview – wallet-ui July 18, 2024 07:40 View deployment

vercel bot deployed to Preview – thirdweb_playground July 18, 2024 07:42 View deployment

vercel bot deployed to Preview – thirdweb-www July 18, 2024 07:53 View deployment

joaquim-verges force-pushed the fix-thirdweb-update-readcontract-options branch from 5462554 to 6cc3038 Compare July 18, 2024 07:55

vercel bot deployed to Preview – thirdweb_playground July 18, 2024 07:59 View deployment

vercel bot deployed to Preview – wallet-ui July 18, 2024 07:59 View deployment

vercel bot deployed to Preview – thirdweb-www July 18, 2024 08:11 View deployment

graphite-app bot merged commit 6cc3038 into main Jul 18, 2024
32 checks passed

graphite-app bot deleted the fix-thirdweb-update-readcontract-options branch July 18, 2024 08:12

vercel bot deployed to Production – thirdweb_playground July 18, 2024 08:14 View deployment

vercel bot deployed to Production – wallet-ui July 18, 2024 08:14 View deployment

jnsdls mentioned this pull request Jul 18, 2024

Version Packages #3722

Merged

vercel bot deployed to Production – thirdweb-www July 18, 2024 08:24 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(thirdweb): add optional 'from' in readContract method #3735

fix(thirdweb): add optional 'from' in readContract method #3735

Uh oh!

joaquim-verges commented Jul 18, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Jul 18, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 18, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 18, 2024

Uh oh!

joaquim-verges commented Jul 18, 2024

Uh oh!

codspeed-hq bot commented Jul 18, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 18, 2024 •

edited

Loading

Uh oh!

jnsdls left a comment

Uh oh!

codecov bot commented Jul 18, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 18, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix(thirdweb): add optional 'from' in readContract method #3735

fix(thirdweb): add optional 'from' in readContract method #3735

Uh oh!

Conversation

joaquim-verges commented Jul 18, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

graphite-app bot commented Jul 18, 2024

Your org requires the Graphite merge queue for merging into main

Uh oh!

joaquim-verges commented Jul 18, 2024

Uh oh!

codspeed-hq bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #3735 will not alter performance

Summary

Uh oh!

github-actions bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

jnsdls left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

joaquim-verges commented Jul 18, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Jul 18, 2024 •

edited

Loading

changeset-bot bot commented Jul 18, 2024 •

edited

Loading

codspeed-hq bot commented Jul 18, 2024 •

edited

Loading

github-actions bot commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

graphite-app bot commented Jul 18, 2024 •

edited

Loading