[Refactor] Simplify RPC client map key usage in getRpcClient function #3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 5c9af85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jnsdls
force-pushed
the
refactor/rpc-client-map-usage
branch
from
7213ddf to
2c788d4
Compare
CodSpeed Performance ReportMerging #3805 will not alter performanceComparing Summary
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3805 +/- ##
==========================================
+ Coverage 62.14% 62.31% +0.16%
==========================================
Files 964 963 -1
Lines 75083 74808 -275
Branches 3770 3768 -2
==========================================
- Hits 46660 46615 -45
+ Misses 27738 27510 -228
+ Partials 685 683 -2
*This pull request uses carry forward flags. Click here to find out more.
|
arcoraven
approved these changes
Jul 25, 2024
Merge activity
|
…#3805) ### TL;DR Fixes an issue with RPC client reuse to improve performance. ### What changed? The change replaces the use of `chainId` with `rpcUrl` as the key in the `rpcClientMap` to ensure the correct RPC client is reused. ### How to test? Test by running existing unit tests and functional tests for RPC client related functionality. Ensure that performance metrics show improvement in RPC client reuse scenarios. ### Why make this change? This change is motivated by the need to improve performance by ensuring the RPC client is correctly reused. ---
jnsdls
force-pushed
the
refactor/rpc-client-map-usage
branch
from
2c788d4 to
5c9af85
Compare
joaquim-verges
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes an issue with RPC client reuse to improve performance.
What changed?
The change replaces the use of
chainIdwithrpcUrlas the key in therpcClientMapto ensure the correct RPC client is reused.How to test?
Test by running existing unit tests and functional tests for RPC client related functionality. Ensure that performance metrics show improvement in RPC client reuse scenarios.
Why make this change?
This change is motivated by the need to improve performance by ensuring the RPC client is correctly reused.
PR-Codex overview
The focus of this PR is to improve performance by fixing the reuse of RPC clients in the
rpc.tsfile.Detailed summary
chainIdtorpcUrlfor clarityrpcUrlinstead ofoptions.chain.rpc