[Fix] Handle account switching inside connected wallet for SIWE auth #3963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2e3c5e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
Playground
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jnsdls
requested review from
joaquim-verges,
gregfromstl and
MananTank
as code owners
jnsdls
force-pushed
the
fix/authentication-account-switch-handling
branch
from
91a7941 to
1556cc7
Compare
size-limit report 📦
|
jnsdls
force-pushed
the
fix/authentication-account-switch-handling
branch
from
1556cc7 to
2982b2c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3963 +/- ##
=======================================
Coverage 60.05% 60.05%
=======================================
Files 962 962
Lines 77543 77545 +2
Branches 3623 3624 +1
=======================================
+ Hits 46569 46571 +2
Misses 30293 30293
Partials 681 681
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
approved these changes
Aug 6, 2024
Merge activity
|
…3963) FIXES: #3912 ### TL;DR This PR fixes the handling of account switching within a connected wallet in Sign-In with Ethereum (SIWE) authentication states. ### What changed? - Updated the `isLoggedIn` function to accept an `address` argument and added more checks to validate the JWT and the associated address. - Pass `account` as a new parameter to `useSiweAuth` to ensure the correct account is handled. - Removed experimental server external packages from `next.config.mjs`. - Removed `@shikijs/twoslash` dependency from `package.json`. ### How to test? 1. Switch accounts within a connected wallet and ensure the SIWE authentication state updates correctly. 2. Verify that the application runs without errors related to the removed experimental packages and dependencies. ### Why make this change? To ensure better account management and state consistency within the SIWE authentication framework, and to remove unused or experimental configurations for better stability and performance. --- <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing account switching in SIWE authentication states. ### Detailed summary - Updated functions to include `account` parameter for SIWE authentication - Changed login and authentication logic - Added `getAuthResult` function for server-side auth - Updated dependencies and imports > The following files were skipped due to too many changes: `pnpm-lock.yaml` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
fix/authentication-account-switch-handling
branch
from
2982b2c to
2e3c5e9
Compare
joaquim-verges
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #3912
TL;DR
This PR fixes the handling of account switching within a connected wallet in Sign-In with Ethereum (SIWE) authentication states.
What changed?
isLoggedInfunction to accept anaddressargument and added more checks to validate the JWT and the associated address.accountas a new parameter touseSiweAuthto ensure the correct account is handled.next.config.mjs.@shikijs/twoslashdependency frompackage.json.How to test?
Why make this change?
To ensure better account management and state consistency within the SIWE authentication framework, and to remove unused or experimental configurations for better stability and performance.
PR-Codex overview
This PR enhances SIWE auth handling in connected wallets.
Detailed summary
useSiweAuthto includeactiveAccount