Skip to content

AA Session Keys docs - small updates #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

edwardysun
Copy link
Contributor

@edwardysun edwardysun commented Sep 6, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to update the user operation process in the smart wallet and adjust account permissions in the portal.

Detailed summary

  • Updated userOp creation to be awaited
  • Renamed smartWallet instances to wallet
  • Adjusted sessionKeyAddress description in permissions
  • Replaced addAdmin with addSessionKey for ERC4337 extensions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 11:17pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 11:17pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 11:17pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 11:17pm

Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: b4ab8cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented Sep 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.81%. Comparing base (775ab6d) to head (b4ab8cd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4451   +/-   ##
=======================================
  Coverage   47.81%   47.81%           
=======================================
  Files        1014     1014           
  Lines       53212    53212           
  Branches     3704     3701    -3     
=======================================
  Hits        25445    25445           
  Misses      27083    27083           
  Partials      684      684           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 775ab6d
packages 43.22% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/lib/userop.ts 80.33% <ø> (ø)

Copy link
Contributor

github-actions bot commented Sep 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.3 KB (0%) 866 ms (0%) 2.2 s (-14.52% 🔽) 3.1 s
thirdweb (cjs) 100.41 KB (0%) 2.1 s (0%) 6.9 s (+10.34% 🔺) 9 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 279 ms (+38.77% 🔺) 375 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 293 ms (+506.2% 🔺) 303 ms
thirdweb/react (minimal + tree-shaking) 16.67 KB (0%) 334 ms (0%) 405 ms (-25.11% 🔽) 738 ms

Copy link
Contributor

graphite-app bot commented Sep 6, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the user operation signing process and renames `smartWallet` to `wallet` for consistency.

### Detailed summary
- Updated user operation signing to be asynchronous
- Renamed `smartWallet` to `wallet` for consistency
- Changed `addAdmin` import to `addSessionKey`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants