Skip to content

Add Account Settings page #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Sep 12, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates titles and layouts in the account and team pages. It also adds confirmation dialogs and improves UI components.

Detailed summary

  • Updated titles in account and team pages
  • Added confirmation dialogs for actions
  • Improved layouts and styles for better UI experience

The following files were skipped due to too many changes: apps/dashboard/src/app/team/[team_slug]/(team)/~/settings/general/GeneralSettingsPage.tsx, apps/dashboard/src/app/account/settings/AccountSettingsPageUI.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 4:38pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 12, 2024 4:38pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 12, 2024 4:38pm
wallet-ui ⬜️ Skipped (Inspect) Sep 12, 2024 4:38pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 12, 2024 12:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 12, 2024 12:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 12, 2024 12:43 Inactive
Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 5385f6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review September 12, 2024 12:43
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 12, 2024
Copy link
Contributor

graphite-app bot commented Sep 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

MananTank commented Sep 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.41%. Comparing base (f092b2a) to head (5385f6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4558   +/-   ##
=======================================
  Coverage   49.41%   49.41%           
=======================================
  Files        1018     1018           
  Lines       53977    53977           
  Branches     3764     3764           
=======================================
  Hits        26671    26671           
  Misses      26673    26673           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f092b2a
packages 45.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 669 ms (+9.1% 🔺) 1.6 s
thirdweb (cjs) 101.04 KB (0%) 2.1 s (0%) 1.7 s (+22.28% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 68 ms (+34.55% 🔺) 165 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 17 ms (-59.57% 🔽) 27 ms
thirdweb/react (minimal + tree-shaking) 16.68 KB (0%) 334 ms (0%) 109 ms (-14.17% 🔽) 443 ms

@MananTank MananTank force-pushed the 09-12-add_account_settings_page branch from c5a10cf to 9364523 Compare September 12, 2024 12:58
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 12, 2024 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 12, 2024 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 12, 2024 12:58 Inactive
@MananTank MananTank force-pushed the 09-12-add_account_settings_page branch from 9364523 to d531ca5 Compare September 12, 2024 13:08
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 12, 2024 13:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 12, 2024 13:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 12, 2024 13:08 Inactive
@MananTank MananTank force-pushed the 09-12-add_account_settings_page branch from d531ca5 to 37de325 Compare September 12, 2024 13:22
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 12, 2024 13:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 12, 2024 13:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 12, 2024 13:23 Inactive
Copy link
Contributor

graphite-app bot commented Sep 12, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates account and team-related UI components and settings pages.

### Detailed summary
- Updated titles in account and team UI components
- Added confirmation dialog to setting cards
- Improved layout in account and team pages
- Implemented account authentication logic

> The following files were skipped due to too many changes: `apps/dashboard/src/app/team/[team_slug]/(team)/~/settings/general/GeneralSettingsPage.tsx`, `apps/dashboard/src/app/account/settings/AccountSettingsPageUI.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 09-12-add_account_settings_page branch from 37de325 to 5385f6b Compare September 12, 2024 16:34
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 12, 2024 16:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 12, 2024 16:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 12, 2024 16:34 Inactive
@graphite-app graphite-app bot merged commit 5385f6b into main Sep 12, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 09-12-add_account_settings_page branch September 12, 2024 16:39
@vercel vercel bot temporarily deployed to Production – docs-v2 September 12, 2024 16:39 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 12, 2024 16:39 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 12, 2024 16:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants