-
Notifications
You must be signed in to change notification settings - Fork 563
[SDK] Fix: pass gasPrice to injected provider #4935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4935 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57241 57242 +1
Branches 3925 3927 +2
=======================================
+ Hits 27256 27257 +1
Misses 29296 29296
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
Merge activity
|
<!-- start pr-codex --> ## PR-Codex overview This PR introduces the handling of `gasPrice` in the transaction object within the `injected` wallet module. ### Detailed summary - Added a new line to handle `gasPrice` in the transaction object. - The `gasPrice` is conditionally converted to hexadecimal format using `numberToHex` if it exists. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
954c2fd
to
c6fbd60
Compare
PR-Codex overview
This PR adds support for
gasPrice
in the transaction object handling within theinjected
wallet module.Detailed summary
gasPrice
in the transaction object.gasPrice
is conditionally set usingnumberToHex(tx.gasPrice)
iftx.gasPrice
exists.