[Dashboard] Abstract code for CSV upload form #5324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
requested review from
jnsdls,
MananTank and
joaquim-verges
as code owners
size-limit report 📦
|
jnsdls
requested changes
Nov 6, 2024
...rc/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/tokens/components/airdrop-upload.tsx
Outdated
Show resolved
Hide resolved
...board)/(chain)/[chain_id]/[contractAddress]/_components/claim-conditions/snapshot-upload.tsx
Outdated
Show resolved
Hide resolved
| previousPage, | ||
| setPageSize, | ||
| state: { pageIndex, pageSize }, | ||
| } = useTable( |
There was a problem hiding this comment.
if we're updating this component lets please update this to tanstack table while we're at it
There was a problem hiding this comment.
Sure. I'll stack up the PRs
kien-ngo
force-pushed
the
kien/snapshot-upload
branch
from
9df1a71 to
888a5cf
Compare
github-actions
bot
added
the
Playground
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5324 +/- ##
=======================================
Coverage 45.76% 45.76%
=======================================
Files 1069 1069
Lines 55606 55606
Branches 4073 4073
=======================================
Hits 25448 25448
Misses 29469 29469
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
kien-ngo
force-pushed
the
kien/snapshot-upload
branch
from
888a5cf to
884d513
Compare
jnsdls
approved these changes
Nov 7, 2024
Merge activity
|
kien-ngo
added a commit
that referenced
this pull request
Nov 7, 2024
DASH-372 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the CSV upload functionality by refactoring components to use a new `useCsvUpload` hook, which centralizes CSV processing logic. It introduces a `CsvDataTable` component for displaying data and improves address validation in the airdrop and snapshot upload processes. ### Detailed summary - Introduced `CsvDataTable` component for displaying CSV data. - Refactored `AirdropUpload` and `SnapshotUpload` to use `useCsvUpload` hook. - Centralized CSV parsing logic in `csvParser` functions. - Improved address validation and error handling in CSV uploads. - Removed redundant address checking functions from `AirdropUpload` and `SnapshotUpload`. - Enhanced pagination and UI updates in CSV data tables. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/snapshot-upload
branch
from
884d513 to
039d39a
Compare
DASH-372 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the CSV upload functionality by refactoring components to use a new `useCsvUpload` hook, which centralizes CSV processing logic. It introduces a `CsvDataTable` component for displaying data and improves address validation in the airdrop and snapshot upload processes. ### Detailed summary - Introduced `CsvDataTable` component for displaying CSV data. - Refactored `AirdropUpload` and `SnapshotUpload` to use `useCsvUpload` hook. - Centralized CSV parsing logic in `csvParser` functions. - Improved address validation and error handling in CSV uploads. - Removed redundant address checking functions from `AirdropUpload` and `SnapshotUpload`. - Enhanced pagination and UI updates in CSV data tables. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/snapshot-upload
branch
from
039d39a to
5216bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DASH-372
PR-Codex overview
This PR focuses on refactoring the
AirdropUploadandSnapshotUploadcomponents to utilize a newuseCsvUploadhook for handling CSV uploads and data processing. It also introduces a newCsvDataTablecomponent for displaying data in a tabular format.Detailed summary
useCsvUploadhook for handling CSV uploads.CsvDataTablefor rendering tabular data.AirdropUploadto useuseCsvUploadandCsvDataTable.SnapshotUploadsimilarly toAirdropUpload.