-
Notifications
You must be signed in to change notification settings - Fork 560
Remove tw-components Checkbox CORE-419 #5890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
=======================================
Coverage 55.37% 55.37%
=======================================
Files 1123 1123
Lines 59642 59642
Branches 5056 5056
=======================================
Hits 33024 33024
Misses 25894 25894
Partials 724 724
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
placement="right" | ||
shouldWrapChildren | ||
> | ||
<ToolTipLabel label="You can only initialize one account per EOA."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could approve this PR but don't merge yet. I'lll double check the code on staging
Merge activity
|
16e8e72
to
fa7fe1e
Compare
CORE-419
PR-Codex overview
This PR primarily focuses on refactoring the use of
Checkbox
components across various files, replacing them withCheckboxWithLabel
for better structure. It also removes the unusedcheckbox.tsx
file.Detailed summary
checkbox.tsx
.Checkbox
in favor ofCheckboxWithLabel
.Tooltip
withToolTipLabel
increate-account-button.tsx
.AddAccessTokenButton
to useCheckboxWithLabel
.BatchLazyMint
to useCheckboxWithLabel
.