Skip to content

Remove tw-components Checkbox CORE-419 #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Jan 6, 2025

CORE-419


PR-Codex overview

This PR primarily focuses on refactoring the use of Checkbox components across various files, replacing them with CheckboxWithLabel for better structure. It also removes the unused checkbox.tsx file.

Detailed summary

  • Deleted checkbox.tsx.
  • Updated imports to remove Checkbox in favor of CheckboxWithLabel.
  • Replaced Tooltip with ToolTipLabel in create-account-button.tsx.
  • Modified AddAccessTokenButton to use CheckboxWithLabel.
  • Adjusted BatchLazyMint to use CheckboxWithLabel.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: fa7fe1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 10:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 6, 2025 10:45pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 6, 2025 10:45pm
wallet-ui ⬜️ Skipped (Inspect) Jan 6, 2025 10:45pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 6, 2025 10:15 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 6, 2025 10:15 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 6, 2025 10:15 Inactive
@kien-ngo kien-ngo changed the title update Remove Jan 6, 2025
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 6, 2025
Copy link
Contributor Author

kien-ngo commented Jan 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kien-ngo kien-ngo changed the title Remove Remove tw-components Checkbox CORE-419 Jan 6, 2025
Copy link

linear bot commented Jan 6, 2025

CORE-419 Remove Checkbox

@kien-ngo kien-ngo marked this pull request as ready for review January 6, 2025 10:15
@kien-ngo kien-ngo requested review from jakubkrehel and a team as code owners January 6, 2025 10:15
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.37%. Comparing base (9bc7884) to head (fa7fe1e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5890   +/-   ##
=======================================
  Coverage   55.37%   55.37%           
=======================================
  Files        1123     1123           
  Lines       59642    59642           
  Branches     5056     5056           
=======================================
  Hits        33024    33024           
  Misses      25894    25894           
  Partials      724      724           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9bc7884
packages 53.06% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45 KB (0%) 900 ms (0%) 2.2 s (-2.33% 🔽) 3.1 s
thirdweb (cjs) 110.81 KB (0%) 2.3 s (0%) 4.5 s (+4.83% 🔺) 6.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 260 ms (+193.49% 🔺) 372 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 110 ms (+110.1% 🔺) 120 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 510 ms (+29.95% 🔺) 892 ms

@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Jan 6, 2025 — with Graphite App
placement="right"
shouldWrapChildren
>
<ToolTipLabel label="You can only initialize one account per EOA.">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could approve this PR but don't merge yet. I'lll double check the code on staging

@MananTank MananTank removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Jan 6, 2025
Copy link
Contributor

graphite-app bot commented Jan 6, 2025

Merge activity

@MananTank MananTank force-pushed the kien/remove-chakra-code branch from 16e8e72 to fa7fe1e Compare January 6, 2025 22:37
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 6, 2025 22:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 6, 2025 22:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 6, 2025 22:37 Inactive
@graphite-app graphite-app bot merged commit fa7fe1e into main Jan 6, 2025
32 checks passed
@graphite-app graphite-app bot deleted the kien/remove-chakra-code branch January 6, 2025 22:46
@vercel vercel bot temporarily deployed to Production – docs-v2 January 6, 2025 22:46 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 6, 2025 22:46 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 6, 2025 22:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants