Skip to content

[SDK]Fix: use base autoconnect in wagmi adapter #6005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Jan 20, 2025

PR-Codex overview

This PR focuses on enhancing the @thirdweb-dev/wagmi-adapter by adding support for accepting URL token parameters during auto-connection and updating the autoConnect function usage.

Detailed summary

  • Added support for URL token parameters in auto-connection.
  • Updated the usage of autoConnect in packages/wagmi-adapter/src/connector.ts.
  • Maintained the existing package.json structure while ensuring dependencies and scripts are preserved.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 20, 2025

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 1:33am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 1:33am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 1:33am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 1:33am

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: dc05f2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/wagmi-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

graphite-app bot commented Jan 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl force-pushed the greg/tool-3157-wagmi-adapter-use-base-autoconnect-function-to-get-tokens-in branch from dc4f399 to ab55682 Compare January 20, 2025 23:20
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.88%. Comparing base (7d9986f) to head (dc05f2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6005   +/-   ##
=======================================
  Coverage   54.88%   54.88%           
=======================================
  Files        1151     1151           
  Lines       61165    61165           
  Branches     5152     5152           
=======================================
  Hits        33573    33573           
  Misses      26864    26864           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7d9986f
packages 52.55% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 476 ms (+124.3% 🔺) 1.5 s
thirdweb (cjs) 116.87 KB (0%) 2.4 s (0%) 642 ms (+4.39% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 82 ms (+125.84% 🔺) 194 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 10 ms (+162.81% 🔺) 20 ms
thirdweb/react (minimal + tree-shaking) 19.19 KB (0%) 384 ms (0%) 109 ms (+97.78% 🔺) 492 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 20, 2025 23:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 20, 2025 23:26 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 20, 2025 23:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 20, 2025 23:26 Inactive
Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you get it to work?

@gregfromstl
Copy link
Member Author

did you get it to work?

Yeah

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 21, 2025
Copy link
Member Author

gregfromstl commented Jan 21, 2025

Merge activity

  • Jan 20, 8:13 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 20, 8:13 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 20, 8:34 PM EST: A user merged this pull request with the Graphite merge queue.

<!-- start pr-codex -->

## PR-Codex overview
This PR introduces minor updates to the `@thirdweb-dev/wagmi-adapter` package, enhancing the autoconnection feature to accept URL token parameters and making adjustments to the package's metadata.

### Detailed summary
- Added support for URL token parameters in the autoconnection feature within `packages/wagmi-adapter/src/connector.ts`.
- Updated the `autoConnect` function call to include `wallets: [wallet]`.
- Minor updates to the `package.json` file's metadata and dependencies.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/tool-3157-wagmi-adapter-use-base-autoconnect-function-to-get-tokens-in branch from f279a72 to dc05f2e Compare January 21, 2025 01:13
@graphite-app graphite-app bot merged commit dc05f2e into main Jan 21, 2025
32 checks passed
@graphite-app graphite-app bot deleted the greg/tool-3157-wagmi-adapter-use-base-autoconnect-function-to-get-tokens-in branch January 21, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants