Skip to content

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 28, 2025

TL;DR

Added billingPlanVersion field to TeamResponse type.

What changed?

Added a new billingPlanVersion number field to the TeamResponse type definition in the service-utils package.

How to test?

  1. Verify that the TeamResponse type includes the billingPlanVersion field
  2. Ensure the field is properly populated when making API calls that return team data
  3. Confirm that existing team-related functionality continues to work as expected

Why make this change?

To track different versions of billing plans for teams, enabling better management and versioning of billing features across the platform.


PR-Codex overview

This PR introduces the billingPlanVersion field to the TeamResponse structure and the relevant parts of the codebase, enhancing the billing information associated with teams.

Detailed summary

  • Added billingPlanVersion with type number to TeamResponse.
  • Updated billingPlanVersion to 1 in mock data within mocks.ts.
  • Modified the api.ts file to include billingPlanVersion in the TeamResponse type definition.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:28am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:28am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:28am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 7:28am

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: c760fec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Jan 28, 2025 — with Graphite App
@jnsdls jnsdls marked this pull request as ready for review January 28, 2025 07:10
@jnsdls jnsdls requested a review from a team as a code owner January 28, 2025 07:10
Copy link
Member Author

jnsdls commented Jan 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (1616b7f) to head (c760fec).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6084   +/-   ##
=======================================
  Coverage   56.81%   56.81%           
=======================================
  Files        1152     1152           
  Lines       63906    63906           
  Branches     5178     5178           
=======================================
  Hits        36311    36311           
  Misses      26865    26865           
  Partials      730      730           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1616b7f
packages 55.00% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 504 ms (+14.74% 🔺) 1.5 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 1.2 s (+9.92% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 108 ms (+52.53% 🔺) 220 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (-58.04% 🔽) 23 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 86 ms (-3.59% 🔽) 471 ms

@jnsdls jnsdls removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Jan 29, 2025
@jnsdls jnsdls merged commit b5e327e into main Jan 29, 2025
37 of 39 checks passed
@jnsdls jnsdls deleted the add_billingPlanVersion_to_TeamResponse branch January 29, 2025 02:21
@joaquim-verges joaquim-verges mentioned this pull request Jan 29, 2025
kumaryash90 added a commit that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants