Skip to content

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Feb 5, 2025

TOOL-0000


PR-Codex overview

This PR focuses on modifying the route definitions in the apps/dashboard/framer-rewrites.js file by removing a specific route.

Detailed summary

  • Removed the route "/connect/pay" from the list of defined routes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners February 5, 2025 19:23
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 7:45pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 5, 2025 7:45pm
login ⬜️ Skipped (Inspect) Feb 5, 2025 7:45pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 5, 2025 7:45pm
wallet-ui ⬜️ Skipped (Inspect) Feb 5, 2025 7:45pm

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 4e9a6c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

graphite-app bot commented Feb 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (769a927) to head (d57b1ae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6178   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files        1155     1155           
  Lines       63923    63923           
  Branches     5193     5193           
=======================================
  Hits        36386    36386           
  Misses      26808    26808           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 769a927
packages 55.12% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 714 ms (+9.09% 🔺) 1.7 s
thirdweb (cjs) 122.38 KB (0%) 2.5 s (0%) 1.5 s (+27.09% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 28 ms (-40.87% 🔽) 140 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 18 ms (+8.74% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 90 ms (-61.42% 🔽) 476 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 5, 2025
Copy link
Member Author

gregfromstl commented Feb 5, 2025

Merge activity

  • Feb 5, 2:42 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 5, 2:42 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 5, 8:43 PM UTC: The Graphite merge queue couldn't merge this PR because it timed out.

TOOL-0000

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on modifying the route definitions in the `apps/dashboard/framer-rewrites.js` file by removing a specific route.

### Detailed summary
- Removed the route `"/connect/pay"` from the list of defined routes.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the fix/remove-pay-framer-page branch from 4e9a6c3 to d57b1ae Compare February 5, 2025 19:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 5, 2025 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 5, 2025 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 5, 2025 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 5, 2025 19:43 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Feb 5, 2025
@joaquim-verges joaquim-verges merged commit c50c82a into main Feb 5, 2025
32 checks passed
@joaquim-verges joaquim-verges deleted the fix/remove-pay-framer-page branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants