-
Notifications
You must be signed in to change notification settings - Fork 570
BREAKING: Removes 3D model support on MediaRenderer #6443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: cca314d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@google/model-viewer@2.1.1 |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6443 +/- ##
==========================================
+ Coverage 54.62% 54.63% +0.01%
==========================================
Files 874 874
Lines 54732 54714 -18
Branches 3708 3708
==========================================
- Hits 29896 29895 -1
+ Misses 24741 24724 -17
Partials 95 95
🚀 New features to boost your workflow:
|
/> | ||
</Suspense> | ||
console.error( | ||
"Encountered an unsupported media type. 3D model support was removed in v5.92.0.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would instead give the dev a hint / link on what to do. Link to Model viewer repo and say something like: "to render 3d models, please use ModelViewer from this repo"
Merge activity
|
PR-Codex overview
This PR focuses on removing support for 3D models in the
MediaRenderer
component of thethirdweb
library, along with some adjustments in the associated files and documentation.Detailed summary
ModelViewer.tsx.changeset/slow-mails-ring.md
.MediaRenderer.tsx
to remove all references to 3D model support.v5.92.0
.ModelViewer
component.