Skip to content

BREAKING: Removes 3D model support on MediaRenderer #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Mar 10, 2025


PR-Codex overview

This PR focuses on removing support for 3D models in the MediaRenderer component of the thirdweb library, along with some adjustments in the associated files and documentation.

Detailed summary

  • Deleted the file ModelViewer.tsx.changeset/slow-mails-ring.md.
  • Updated MediaRenderer.tsx to remove all references to 3D model support.
  • Added a note in the documentation indicating that 3D models are no longer supported as of version v5.92.0.
  • Removed the import of the ModelViewer component.
  • Adjusted error messages for unsupported media types and video playback.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners March 10, 2025 02:25
Copy link

linear bot commented Mar 10, 2025

Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: cca314d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 3:49am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 3:49am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 3:49am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 3:49am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 3:49am

Copy link
Contributor

graphite-app bot commented Mar 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 10, 2025
Copy link

socket-security bot commented Mar 10, 2025

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@google/model-viewer@2.1.1

View full report↗︎

Copy link
Contributor

github-actions bot commented Mar 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 172 ms (+99.45% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 260 ms (+4.1% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 94 ms (+1164.46% 🔺) 206 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 16 ms (+348.86% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 46 ms (+107.78% 🔺) 433 ms

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.63%. Comparing base (d350f8c) to head (225317b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...b/src/react/web/ui/MediaRenderer/MediaRenderer.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6443      +/-   ##
==========================================
+ Coverage   54.62%   54.63%   +0.01%     
==========================================
  Files         874      874              
  Lines       54732    54714      -18     
  Branches     3708     3708              
==========================================
- Hits        29896    29895       -1     
+ Misses      24741    24724      -17     
  Partials       95       95              
Flag Coverage Δ
packages 54.63% <20.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...b/src/react/web/ui/MediaRenderer/MediaRenderer.tsx 40.57% <20.00%> (+1.25%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/>
</Suspense>
console.error(
"Encountered an unsupported media type. 3D model support was removed in v5.92.0.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would instead give the dev a hint / link on what to do. Link to Model viewer repo and say something like: "to render 3d models, please use ModelViewer from this repo"

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 10, 2025
Copy link
Member Author

gregfromstl commented Mar 10, 2025

Merge activity

  • Mar 9, 11:34 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 9, 11:47 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants