Skip to content

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Mar 10, 2025


PR-Codex overview

This PR focuses on renaming and updating the RoutesPage component, enhancing the route data structure by adding new properties, and modifying the UI components to accommodate these changes, including adjustments to icon handling and styling.

Detailed summary

  • Renamed ChainListPage to RoutesPage.
  • Updated iconUri in route types to be optional and added name and symbol.
  • Increased filters.limit from 10,000 to 50,000.
  • Added originTokenSymbol, originTokenName, destinationTokenSymbol, and destinationTokenName to route data.
  • Modified RouteListRow and RouteListCard components to include new token properties.
  • Updated icon handling and styling in both RouteListRow and RouteListCard components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners March 10, 2025 04:39
Copy link

linear bot commented Mar 10, 2025

Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: dd06be8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:03am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 10, 2025 5:03am
login ⬜️ Skipped (Inspect) Mar 10, 2025 5:03am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 10, 2025 5:03am
wallet-ui ⬜️ Skipped (Inspect) Mar 10, 2025 5:03am

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 10, 2025
Copy link
Contributor

graphite-app bot commented Mar 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel vercel bot temporarily deployed to Preview – login March 10, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 10, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 10, 2025 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 10, 2025 04:41 Inactive
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.63%. Comparing base (bf8da35) to head (dd06be8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6446   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files         874      874           
  Lines       54714    54714           
  Branches     3709     3709           
=======================================
  Hits        29895    29895           
  Misses      24724    24724           
  Partials       95       95           
Flag Coverage Δ
packages 54.63% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Mar 10, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 236 ms (+100.41% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 386 ms (+21.1% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 96 ms (+823.42% 🔺) 208 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (+363.91% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 92 ms (+244.27% 🔺) 479 ms

@gregfromstl gregfromstl force-pushed the greg/tool-3667-ub-update-routes-ui-to-show-beyond-10000-routes branch from 8d24096 to 771b2fa Compare March 10, 2025 04:47
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 10, 2025 04:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 10, 2025 04:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 10, 2025 04:48 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 10, 2025 04:48 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 10, 2025
Copy link
Member Author

gregfromstl commented Mar 10, 2025

Merge activity

  • Mar 10, 12:55 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 10, 12:56 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 10, 1:04 AM EDT: A user merged this pull request with the Graphite merge queue.

…es (#6446)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on renaming and updating the `RoutesPage` functionality, enhancing token properties, and adjusting UI elements in the routing components for better clarity and usability.

### Detailed summary
- Renamed `ChainListPage` to `RoutesPage`.
- Updated token properties to include `name` and `symbol` for both origin and destination tokens.
- Increased `filters.limit` from `10,000` to `50,000`.
- Modified UI classes for improved styling and consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the greg/tool-3667-ub-update-routes-ui-to-show-beyond-10000-routes branch from 771b2fa to dd06be8 Compare March 10, 2025 04:57
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 10, 2025 04:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 10, 2025 04:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 10, 2025 04:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 10, 2025 04:57 Inactive
@graphite-app graphite-app bot merged commit dd06be8 into main Mar 10, 2025
32 checks passed
@graphite-app graphite-app bot deleted the greg/tool-3667-ub-update-routes-ui-to-show-beyond-10000-routes branch March 10, 2025 05:04
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Mar 10, 2025
@vercel vercel bot temporarily deployed to Production – login March 10, 2025 05:04 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 10, 2025 05:04 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 10, 2025 05:04 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 10, 2025 05:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants