Skip to content

[NEB-179] Nebula: Update context UI when context event type is received #6770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Apr 18, 2025


PR-Codex overview

This PR focuses on enhancing the ChatSidebar, ChatPageContent, and FloatingChatContent components by adding context handling and modifying how context filters are managed. It also improves the markdown-renderer logic for code highlighting and updates the handling of streamed events.

Detailed summary

  • Updated ChatSidebar to include a detailsButtonClassName prop in NebulaConnectWallet.
  • Enhanced markdown-renderer to check for class names and text length for code highlighting.
  • Added handling for "context" events in the chat API, parsing data for wallet address and chain IDs.
  • Modified ChatPageContent to include setContextFilters in dependencies and state management.
  • Updated handleNebulaPrompt to process "context" events and set context filters accordingly.
  • Changed FloatingChatContent to use useState for contextFilters instead of useMemo.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Apr 18, 2025

Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: d0bf3f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 8:56pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 18, 2025 8:56pm
login ⬜️ Skipped (Inspect) Apr 18, 2025 8:56pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 18, 2025 8:56pm
wallet-ui ⬜️ Skipped (Inspect) Apr 18, 2025 8:56pm

@vercel vercel bot temporarily deployed to Preview – login April 18, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 18, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 18, 2025 16:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 18, 2025 16:30 Inactive
@MananTank MananTank marked this pull request as ready for review April 18, 2025 16:30
@MananTank MananTank requested review from a team as code owners April 18, 2025 16:30
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 18, 2025
Copy link
Member Author

MananTank commented Apr 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (96689c6) to head (d0bf3f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6770   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files         896      896           
  Lines       56924    56924           
  Branches     3943     3943           
=======================================
  Hits        31412    31412           
  Misses      25416    25416           
  Partials       96       96           
Flag Coverage Δ
packages 55.18% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – login April 18, 2025 16:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 18, 2025 16:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 18, 2025 16:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 18, 2025 16:34 Inactive
Copy link
Contributor

github-actions bot commented Apr 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.71 KB (0%) 1.1 s (0%) 218 ms (+132.98% 🔺) 1.3 s
thirdweb (cjs) 138.82 KB (0%) 2.8 s (0%) 321 ms (+35.43% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 75 ms (+674.09% 🔺) 187 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 45 ms (+1222.46% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 125 ms (+590.41% 🔺) 512 ms

Copy link
Contributor

graphite-app bot commented Apr 18, 2025

Merge activity

…ed (#6770)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ChatSidebar`, `ChatPageContent`, and `FloatingChatContent` components by adding new properties and functionality related to context management and event handling within the chat application.

### Detailed summary
- Updated `<NebulaConnectWallet />` to accept `detailsButtonClassName` prop.
- Improved `code` component to handle class names and text length conditions.
- Added new event handling for "context" in the chat API.
- Extended `ChatStreamedResponse` and `ChatStreamedEvent` types to include "context" data.
- Integrated `setContextFilters` functionality in `ChatPageContent` and `FloatingChatContent` components.
- Refactored `contextFilters` state management in `FloatingChatContent`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 18, 2025 20:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 18, 2025 20:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 18, 2025 20:49 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 18, 2025 20:49 Inactive
Base automatically changed from neb-176 to main April 18, 2025 20:56
@graphite-app graphite-app bot merged commit d0bf3f3 into main Apr 18, 2025
21 checks passed
@graphite-app graphite-app bot deleted the neb-179 branch April 18, 2025 20:57
@vercel vercel bot temporarily deployed to Production – login April 18, 2025 20:57 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 18, 2025 20:57 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 18, 2025 20:57 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 18, 2025 20:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants