[Dashboard] Fix: Display latest value in PayNewCustomers component #7002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
gregfromstl
added
the
merge-queue
github-actions
bot
added
Dashboard
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7002 +/- ##
=======================================
Coverage 54.60% 54.60%
=======================================
Files 903 903
Lines 57936 57936
Branches 3971 3971
=======================================
Hits 31638 31638
Misses 26197 26197
Partials 101 101
🚀 New features to boost your workflow:
|
size-limit report 📦
|
joaquim-verges
approved these changes
May 10, 2025
gregfromstl
added
the
merge-queue
Merge activity
|
…7002) 🤖 Generated with [Claude Code](https://claude.ai/code) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the logic used to display the total value in the `SkeletonContainer` of the `PayNewCustomers` component. It ensures that when `graphData` is empty, it returns "NA", and otherwise, it retrieves the last value or defaults to 0. ### Detailed summary - Updated the logic in `SkeletonContainer`: - Changed the expression to return `graphData[graphData.length - 1]?.value || 0` when `graphData` is not empty. - Maintained the output of "NA" when `isEmpty` is true. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
greg/fix-new-customers-total-count
branch
from
f1cddd6 to
816aa61
Compare
graphite-app
bot
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
PR-Codex overview
This PR updates the logic for displaying the total value of new customers in the
PayNewCustomerscomponent. It changes how the value is computed when thegraphDatais empty or when accessing the latest value.Detailed summary
loadedDataprop in theSkeletonContainer.curr.valueto retrieving the last value ingraphDataor returning0if not available.graphDatais empty by displaying "NA".