Skip to content

[Dashboard] Fix: Copying payment link on iOS #7008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented May 11, 2025


PR-Codex overview

This PR primarily focuses on improving error handling, refactoring components, and enhancing the PaymentLinkForm functionality within the dashboard application. It includes better error messages, updates to layout components, and adjustments to the payment link generation process.

Detailed summary

  • Improved error handling in getCurrencyMetadata by including the caught error in the message.
  • Renamed CheckoutLayout to PayLayout.
  • Simplified PaymentLinkForm by removing the client prop.
  • Added state for paymentUrl in PaymentLinkForm.
  • Updated the payment link creation process to set paymentUrl and show success messages.
  • Enhanced the layout of the PaymentLinkForm with a new copy button for the payment link.
  • Adjusted CSS classes for improved styling and functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 11, 2025 07:57
Copy link

changeset-bot bot commented May 11, 2025

⚠️ No Changeset found

Latest commit: fdbb5ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 8:16am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 8:16am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 11, 2025 8:16am
thirdweb_playground ⬜️ Skipped (Inspect) May 11, 2025 8:16am
wallet-ui ⬜️ Skipped (Inspect) May 11, 2025 8:16am

Copy link
Contributor

graphite-app bot commented May 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label May 11, 2025
Copy link
Member Author

Merge activity

  • May 11, 3:57 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK labels May 11, 2025
Copy link
Contributor

github-actions bot commented May 11, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 196 ms (+196.04% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 388 ms (+37.2% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 84 ms (+2113.26% 🔺) 198 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 44 ms (+1857.79% 🔺) 54 ms
thirdweb/react (minimal + tree-shaking) 19.55 KB (0%) 391 ms (0%) 121 ms (+859.8% 🔺) 512 ms

…lient.tsx

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Signed-off-by: greg <gregfromstl@gmail.com>
@gregfromstl gregfromstl force-pushed the greg/fix-ios-payment-link-copy branch from 7ff4e92 to fdbb5ab Compare May 11, 2025 08:05
@vercel vercel bot temporarily deployed to Preview – login May 11, 2025 08:05 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 11, 2025 08:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 11, 2025 08:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 11, 2025 08:05 Inactive
@gregfromstl gregfromstl merged commit 557a29a into main May 11, 2025
19 of 20 checks passed
@gregfromstl gregfromstl deleted the greg/fix-ios-payment-link-copy branch May 11, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant