Nebula: Fix User Image message type #7018
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7018 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 904 904
Lines 57991 57991
Branches 4004 4004
=======================================
Hits 31731 31731
Misses 26155 26155
Partials 105 105
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the image handling in the `types.ts` and related components by modifying the structure of image objects, allowing for optional `image_url` and `b64` properties.
### Detailed summary
- In `types.ts`, changed the `image` type to include `image_url: string | null` and `b64: string | null`.
- In `ChatBar.tsx`, added `image_url: null` when pushing the image object to `userMessage.content`.
- In `Chats.tsx`, updated the condition to check if `msg.b64` is a string and used `msg.image_url ?? ""` for the URL.
- In `NebulaImage.tsx`, adjusted the skeleton div to have a minimum height of 300px.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
graphite-app
bot
force-pushed
the
05-12-nebula_fix_user_image_message_type
branch
from
82fd401 to
a3a4bf4
Compare
PR-Codex overview
This PR focuses on updating the data structure for image handling in the application by modifying the
types.tsfile and adjusting related components to accommodate new properties.Detailed summary
types.ts, changed theimagetype to includeimage_urlandb64as nullable strings.ChatBar.tsx, addedimage_url: nullwhen pushing image messages.Chats.tsx, modified the URL handling to useimage_urlwith a fallback to an empty string.NebulaImage.tsx, updated the skeleton div to have a minimum height.