-
Notifications
You must be signed in to change notification settings - Fork 561
[TOOL-5021] SDK: Fix theme in ConnectButton Details Modal Buy screen #7589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-5021] SDK: Fix theme in ConnectButton Details Modal Buy screen #7589
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c0fe9c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
3e45e9d
to
d62e997
Compare
be37931
to
c0fe9c6
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7589 +/- ##
=======================================
Coverage 56.48% 56.48%
=======================================
Files 906 906
Lines 58070 58075 +5
Branches 4230 4228 -2
=======================================
+ Hits 32801 32805 +4
Misses 25160 25160
- Partials 109 110 +1
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on enhancing the
ConnectButton
component by adding theme support and styling in theDetails
modal, as well as introducing a new story for a custom dark theme.Detailed summary
theme
prop toDetails
modal inpackages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx
.CustomBlack
inpackages/thirdweb/src/stories/ConnectButton/themes.stories.tsx
for a dark theme variation.