-
Notifications
You must be signed in to change notification settings - Fork 565
Dashboard: Migrate contract/settings page from chakra to tailwind #7752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Migrate contract/settings page from chakra to tailwind #7752
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
bbe45ba
to
0e19eca
Compare
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7752 +/- ##
=======================================
Coverage 56.42% 56.42%
=======================================
Files 904 904
Lines 58665 58665
Branches 4135 4135
=======================================
Hits 33100 33100
Misses 25460 25460
Partials 105 105
🚀 New features to boost your workflow:
|
Merge activity
|
51c3d09
to
a757938
Compare
0e19eca
to
8d2bc57
Compare
8d2bc57
to
e4c29d6
Compare
a757938
to
00c95a2
Compare
) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the `ContractSettingsPage` and its components to improve code structure and readability. It introduces a new UI library for forms and enhances the user experience with better layout and error handling. ### Detailed summary - Refactored `ContractSettingsPage` to use `div` and `cn` for layout instead of `Flex` and `GridItem`. - Updated `ContractSettingsPageInner` to accept props directly instead of using an interface. - Replaced `Card` and `Flex` components with `div` and new UI components for a cleaner look. - Introduced new form components (`Form`, `FormControl`, etc.) for better organization and handling. - Enhanced error handling for form submissions with toast notifications. - Updated styling for a more modern UI approach across all settings components. - Simplified the logic for rendering settings components based on their support status. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
00c95a2
to
fad7cb9
Compare
e4c29d6
to
6b9f29d
Compare
PR-Codex overview
This PR focuses on refactoring the
ContractSettingsPage
and its components to enhance the UI structure and improve the use of form handling with a new UI library. It replaces Chakra UI components with a custom form system and optimizes the layout for better usability.Detailed summary
ContractSettingsPage
to use a custom layout withdiv
andcn
for class management.ContractSettingsPageInner
to accept props directly instead of an interface.SettingsPrimarySale
,SettingsRoyalties
,SettingsPlatformFees
, andSettingsMetadata
.react-hook-form
with customForm
,FormField
,FormItem
, etc.toast
.