Skip to content

Dashboard: Migrate contract/settings page from chakra to tailwind #7752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Jul 29, 2025


PR-Codex overview

This PR focuses on refactoring the ContractSettingsPage and its components to enhance the UI structure and improve the use of form handling with a new UI library. It replaces Chakra UI components with a custom form system and optimizes the layout for better usability.

Detailed summary

  • Refactored ContractSettingsPage to use a custom layout with div and cn for class management.
  • Updated ContractSettingsPageInner to accept props directly instead of an interface.
  • Replaced Chakra UI components with custom form components in SettingsPrimarySale, SettingsRoyalties, SettingsPlatformFees, and SettingsMetadata.
  • Enhanced form handling using react-hook-form with custom Form, FormField, FormItem, etc.
  • Improved error handling and user notifications using toast.
  • Adjusted layout and styling for better responsiveness and usability across components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 6:26pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 29, 2025 6:26pm
nebula ⬜️ Skipped (Inspect) Jul 29, 2025 6:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 29, 2025 6:26pm
wallet-ui ⬜️ Skipped (Inspect) Jul 29, 2025 6:26pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 July 29, 2025 15:40 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 29, 2025 15:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 29, 2025 15:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 29, 2025 15:40 Inactive
Copy link

changeset-bot bot commented Jul 29, 2025

⚠️ No Changeset found

Latest commit: 6b9f29d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 07-29-dashboard_migrate_contract_settings_page_from_chakra_to_tailwind

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member Author

MananTank commented Jul 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 07-29-dashboard_migrate_contract_settings_page_from_chakra_to_tailwind branch from bbe45ba to 0e19eca Compare July 29, 2025 15:43
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 29, 2025 15:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 29, 2025 15:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 29, 2025 15:43 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula July 29, 2025 15:43 Inactive
Copy link
Contributor

github-actions bot commented Jul 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.16 KB (0%) 1.3 s (0%) 288 ms (+139.78% 🔺) 1.6 s
thirdweb (cjs) 352.91 KB (0%) 7.1 s (0%) 1.1 s (+15.75% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 138 ms (+2064.2% 🔺) 252 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 53 ms (+1933.85% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 135 ms (+600.37% 🔺) 520 ms

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.42%. Comparing base (fad7cb9) to head (6b9f29d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7752   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         904      904           
  Lines       58665    58665           
  Branches     4135     4135           
=======================================
  Hits        33100    33100           
  Misses      25460    25460           
  Partials      105      105           
Flag Coverage Δ
packages 56.42% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

graphite-app bot commented Jul 29, 2025

Merge activity

)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `ContractSettingsPage` and its components to improve code structure and readability. It introduces a new UI library for forms and enhances the user experience with better layout and error handling.

### Detailed summary
- Refactored `ContractSettingsPage` to use `div` and `cn` for layout instead of `Flex` and `GridItem`.
- Updated `ContractSettingsPageInner` to accept props directly instead of using an interface.
- Replaced `Card` and `Flex` components with `div` and new UI components for a cleaner look.
- Introduced new form components (`Form`, `FormControl`, etc.) for better organization and handling.
- Enhanced error handling for form submissions with toast notifications.
- Updated styling for a more modern UI approach across all settings components.
- Simplified the logic for rendering settings components based on their support status.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 07-29-dashboard_migrate_contract_proposals_from_chakra_to_tailwind branch from 00c95a2 to fad7cb9 Compare July 29, 2025 18:17
@graphite-app graphite-app bot force-pushed the 07-29-dashboard_migrate_contract_settings_page_from_chakra_to_tailwind branch from e4c29d6 to 6b9f29d Compare July 29, 2025 18:17
@vercel vercel bot temporarily deployed to Preview – nebula July 29, 2025 18:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 29, 2025 18:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 29, 2025 18:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 29, 2025 18:17 Inactive
Base automatically changed from 07-29-dashboard_migrate_contract_proposals_from_chakra_to_tailwind to main July 29, 2025 18:27
@graphite-app graphite-app bot merged commit 6b9f29d into main Jul 29, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 07-29-dashboard_migrate_contract_settings_page_from_chakra_to_tailwind branch July 29, 2025 18:28
@vercel vercel bot temporarily deployed to Production – wallet-ui July 29, 2025 18:28 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 July 29, 2025 18:28 Inactive
@vercel vercel bot temporarily deployed to Production – nebula July 29, 2025 18:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground July 29, 2025 18:28 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www July 29, 2025 18:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants