Skip to content

Fix: Add brief pause after onramp #8052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Fix: Add brief pause after onramp #8052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/floppy-clocks-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Prevents incorrect failures in widget onramps.
5 changes: 5 additions & 0 deletions packages/thirdweb/src/react/core/hooks/useStepExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,11 @@

const status = statusResult.status;
if (status === "COMPLETED") {
/*
* The occasional race condition can happen where the onramp provider gives us completed status before the token balance has updated in our RPC.
* We add this pause so the simulation doesn't fail on the next step.
*/
await new Promise((resolve) => setTimeout(resolve, 2000));

Check warning on line 379 in packages/thirdweb/src/react/core/hooks/useStepExecutor.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/core/hooks/useStepExecutor.ts#L379 

Added line #L379 was not covered by tests
setOnrampStatus("completed");
// Add type field for discriminated union
const typedStatusResult = {
Expand Down
Loading