Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

New generic contract.call(fn, args) for custom contracts #424

Merged
merged 6 commits into from
May 28, 2022
Merged

New generic contract.call(fn, args) for custom contracts #424

merged 6 commits into from
May 28, 2022

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 27, 2022 •
edited
Loading

Replaces the current pattern of

contract.functions.myFunction(arg1, arg2)
to
contract.call("myFunction", arg1, arg2)

this gives us a few advantages:

  • always await tx confirmations
  • supports gasless transactions
  • properly route read vs write functions appropriately.

@joaquim-verges joaquim-verges requested review from jnsdls and adam-maj May 27, 2022 22:26
@joaquim-verges joaquim-verges merged commit 7542321 into main May 28, 2022
@joaquim-verges joaquim-verges deleted the joaquim/custom_function_api branch May 28, 2022 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@adam-maj adam-maj Awaiting requested review from adam-maj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joaquim-verges