This repository was archived by the owner on Aug 30, 2022. It is now read-only.
Bugfix - Incorrect entrypoint being loaded when using Node ESModules #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to load the SDK from a Node script the Browser package is being loaded. This is because `module` does not appear to be a [known condition](https://nodejs.org/api/packages.html#conditional-exports) and therefore it skips and ends up loading the `default` ESModule.
jameshowe
changed the title
jameshowe
changed the title
jnsdls
suggested changes
Jun 2, 2022
Include 'module' Co-authored-by: Jonas Daniels <jonas.daniels@outlook.com>
jnsdls
approved these changes
Jun 2, 2022
|
thanks @jameshowe! |
No worries! Any view on when this will be released? (I can patch my local version just now) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to load the SDK from a Node script the Browser package is being loaded. This is because
moduledoes not appear to be a known condition and therefore it skips and loads thedefaultentrypoint (browser).