This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Rename IpfsUploader to PinataUploader #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-maj
commented
Jul 1, 2022
| @@ -297,7 +297,7 @@ export class IpfsStorage implements IStorage { | |||
| signerAddress?: string, | |||
| ): Promise<string> { | |||
| // TODO move down to IStorageUpload | |||
| const token = await (this.uploader as IpfsUploader).getUploadToken( | |||
| const token = await (this.uploader as PinataUploader).getUploadToken( | |||
There was a problem hiding this comment.
Do we really need this function here? It's doing a lot of things that we shouldn't be doing - for one it's using an internal function of a single IPFS implementation in the top-level class (this won't work once we add more uploaders), and also its exposed publicly even though its marked as internal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.