This repository was archived by the owner on Aug 30, 2022. It is now read-only.
Rename PriceSchema to AmountSchema #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsdls
approved these changes
Jul 28, 2022
src/schema/shared.ts
Outdated
| @@ -84,6 +84,13 @@ export const RawDateSchema = z.date().transform((i) => { | |||
| return BigNumber.from(Math.floor(i.getTime() / 1000)); | |||
| }); | |||
|
|
|||
| export const AirdropQuantitySchema = z | |||
There was a problem hiding this comment.
I think we already have an alias for Price that is "Amount" - can you use that instead?
There was a problem hiding this comment.
not sure what you mean here, I added this because I realized the error message for airdrop when invalid quantity was wrong
There was a problem hiding this comment.
lets just call this AmountSchema and use it for the Amount type
joaquim-verges
approved these changes
Aug 23, 2022
src/schema/shared.ts
Outdated
| @@ -84,6 +84,13 @@ export const RawDateSchema = z.date().transform((i) => { | |||
| return BigNumber.from(Math.floor(i.getTime() / 1000)); | |||
| }); | |||
|
|
|||
| export const AirdropQuantitySchema = z | |||
There was a problem hiding this comment.
lets just call this AmountSchema and use it for the Amount type
…into ni/use-custom-schema-for-airdrop
nachoiacovino
changed the title
joaquim-verges
suggested changes
Aug 24, 2022
| @@ -32,7 +32,7 @@ export async function normalizePriceValue( | |||
| currencyAddress: string, | |||
| ) { | |||
| const metadata = await fetchCurrencyMetadata(provider, currencyAddress); | |||
| return utils.parseUnits(PriceSchema.parse(inputPrice), metadata.decimals); | |||
| return utils.parseUnits(AmountSchema.parse(inputPrice), metadata.decimals); | |||
There was a problem hiding this comment.
this was PriceSchema - why is it changed?
| @@ -39,10 +39,10 @@ export type TokenHolderBalance = { holder: string; balance: CurrencyValue }; | |||
| * Represents a currency price already formatted. ie. "1" for 1 ether. | |||
| * @public | |||
| */ | |||
| export type Price = z.input<typeof PriceSchema>; | |||
| export type Price = z.input<typeof AmountSchema>; | |||
There was a problem hiding this comment.
why did you change this one? this should not be changed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we get a correct error message if they submit an invalid quantity