Skip to content

isApproved -> setApprovalForAll string fix ERC721/ERC1155 libs #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 30, 2022
Merged

isApproved -> setApprovalForAll string fix ERC721/ERC1155 libs #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1092219
Throw exceptions, let unity dev handle them
0xFirekeeper Nov 27, 2022
764acaa
Merge remote-tracking branch 'upstream/main'
0xFirekeeper Nov 28, 2022
3531fa9
Merge remote-tracking branch 'upstream/main'
0xFirekeeper Nov 28, 2022
361dc8e
Merge remote-tracking branch 'upstream/main'
0xFirekeeper Nov 28, 2022
3aaa564
Merge remote-tracking branch 'upstream/main'
0xFirekeeper Nov 29, 2022
8411f47
Eth <> Wei + ERC20 Formatting functions for Utils.cs
0xFirekeeper Nov 29, 2022
1eb0cde
String arguments and return values instead
0xFirekeeper Nov 29, 2022
9fd885c
useless cast removed
0xFirekeeper Nov 29, 2022
abd4a59
OCD
0xFirekeeper Nov 29, 2022
662e0eb
TryParse instead of Parse
0xFirekeeper Nov 29, 2022
f4fe547
Swap out argument positions for better ux
0xFirekeeper Nov 29, 2022
c86b269
throw exceptions + ToEth uses FormatERC20 exposing decimalsToDisplay
0xFirekeeper Nov 29, 2022
ed6a9c1
Merge remote-tracking branch 'upstream/main'
0xFirekeeper Nov 29, 2022
cc07f4c
ToString overrides on ALL types
0xFirekeeper Nov 29, 2022
8ebeda6
Merge remote-tracking branch 'upstream/main'
0xFirekeeper Nov 29, 2022
e8099f4
Merge remote-tracking branch 'upstream/main'
0xFirekeeper Nov 30, 2022
65c9612
Fix setApprovalForAll
0xFirekeeper Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Assets/Thirdweb/Scripts/ERC1155.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public async Task<int> TotalSupply(string tokenId)
/// </summary>
public async Task<TransactionResult> SetApprovalForAll(string contractToApprove, bool approved)
{
return await Bridge.InvokeRoute<TransactionResult>(getRoute("isApproved"), Utils.ToJsonStringArray(contractToApprove, approved));
return await Bridge.InvokeRoute<TransactionResult>(getRoute("setApprovalForAll"), Utils.ToJsonStringArray(contractToApprove, approved));
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Assets/Thirdweb/Scripts/ERC721.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public async Task<int> TotalUnclaimedSupply()
/// </summary>
public async Task<TransactionResult> SetApprovalForAll(string contractToApprove, bool approved)
{
return await Bridge.InvokeRoute<TransactionResult>(getRoute("isApproved"), Utils.ToJsonStringArray(contractToApprove, approved));
return await Bridge.InvokeRoute<TransactionResult>(getRoute("setApprovalForAll"), Utils.ToJsonStringArray(contractToApprove, approved));
}

/// <summary>
Expand Down