-
Notifications
You must be signed in to change notification settings - Fork 81
Upgrade MetaMask SDK to 1.3.1 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @ecp4224 testing this cross platform now. Can you set UnityUI ScriptableObject back to Spawn Canvas being off - currently MM canvas being spawned behind WalletProvider_MetaMask prefab - thanks |
Unable to build for Windows, guessing the new editor script / assembly change made to ThirdwebCore causing issues Would remove that editor script or move it to higher up editor folder where Thirdweb.Editor.MetaMask asmdef lives |
Done 👍
I moved it to |
Able to build successfully on standalone and mobile, any other notable/functional changes I should be aware of that you'd like to communicate before shipping this? @ecp4224 |
The only notable thing to mention is that the WebGL build now uses the MetaMask JS SDK, however after reviewing the changes here, I remembered that we have the JS SDK bundled into our own WebGL Template (not included here). Wondering how this should be bundled into the Thirdweb WebGL Template? I can grab it dynamically or I can just add the following script tag
I can also simply disable the JS SDK Provider in |
In WebGL we use our own template which uses our metamask wallet implementation from our typescript sdk bridge, so yes we don't need WebGL specific libs from the MM Unity SDK but it's okay to leave them in here for now |
Other than the added extra GUID in our asmdef this is good to go, let me know if it points to anything on your end, points to nothing on my end. Thanks. |
I've commented out the JS SDK Provider for now and all build platforms will use the same provider logic. Perhaps in the future we can revisit this to use MetaMask JS SDK inside the typescript sdk bridge 😄 I've also removed the unused GUID, unsure why Unity / Rider added this. |
Happy to get it done on the typescript side later on. LGTM, thanks Eddie. |
This PR upgrades the MetaMask SDK to the latest version 1.3.1, which fixes several bugs and adds some new features:
Bug Fixes
TERMINATE
message whenEndSession()
is usedFeatures
MetaMask/Runtime
into singledll
for both .NET Standard 2.0 and .NET Standard 2.1ConnectAndSign()
function