Skip to content

Silent op revert handling in Transaction.WaitForTransactionResult #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Apr 1, 2024

PR-Codex overview

The focus of this PR is to enhance error handling and deployment status checking in the SmartWallet and Transaction classes.

Detailed summary

  • Added logic to check for successful deployment in SmartWallet.cs
  • Improved error handling for transaction failures in Transaction.cs
  • Added decoding of revert reasons for failed transactions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Apr 1, 2024

Test Results for Android

  1 files  ±0   15 suites  ±0   6m 48s ⏱️ -11s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0c85a81. ± Comparison against base commit 380eaf0.

Copy link

github-actions bot commented Apr 1, 2024

Test Results for iOS

  1 files  ±0   15 suites  ±0   6m 43s ⏱️ -3s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0c85a81. ± Comparison against base commit 380eaf0.

Copy link

github-actions bot commented Apr 1, 2024

Test Results for StandaloneLinux64

  1 files  ±0   15 suites  ±0   6m 46s ⏱️ +15s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0c85a81. ± Comparison against base commit 380eaf0.

Copy link

github-actions bot commented Apr 1, 2024

Test Results for WebGL

  1 files  ±0   15 suites  ±0   7m 49s ⏱️ + 1m 13s
 96 tests ±0   96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0c85a81. ± Comparison against base commit 380eaf0.

@0xFirekeeper 0xFirekeeper merged commit 6ae5fbc into main Apr 1, 2024
@0xFirekeeper 0xFirekeeper deleted the firekeeper/silentrevert branch April 1, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant