Skip to content

Backend Auth + ThirdwebManagerServer #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jan 10, 2025

Adds AuthProvider.Backend's related walletSecret In-App and Ecosystem Wallet Options Parameter.

Splits ThirdwebManager (and its editor script) into ThirdwebManagerBase, ThirdwebManager (frontend), ThirdwebManagerServer (Backend)

Adds ThirdwebManagerServer prefab, uses SecretKey instead of ClientId and BundleId.

Adds a lot of flexibility and extendability for various use cases.

Closes TOOL-3022


PR-Codex overview

This PR focuses on refactoring the ThirdwebManager class to inherit from ThirdwebManagerBase, enhancing the structure and functionality of wallet management in the Thirdweb Unity SDK.

Detailed summary

  • Refactored ThirdwebManager to inherit from ThirdwebManagerBase.
  • Updated method calls to use ThirdwebManagerBase.Instance.
  • Added SecretKey property in ThirdwebManagerServer.
  • Implemented ThirdwebManagerServer class for server-side functionality.
  • Modified editor scripts to support new structure.
  • Enhanced error handling and logging for wallet connections.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Adds `AuthProvider.Backend`'s related `walletSecret` In-App and Ecosystem Wallet Options Parameter.

Splits ThirdwebManager (and its editor script) into ThirdwebManagerBase, ThirdwebManager (frontend), ThirdwebManager (Backend)

Adds ThirdwebManagerServer prefab, uses SecretKey instead of ClientId and BundleId.

Adds a lot of flexibility and extendability for various use cases.

TOOL-3022
Copy link

linear bot commented Jan 10, 2025

@0xFirekeeper 0xFirekeeper merged commit ded83a7 into v5 Jan 10, 2025
4 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/backend-auth-tw-server branch January 10, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant