Transaction API #75
Merged
Transaction API #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return this; | ||
| } | ||
|
|
||
| public Transaction SetGas(string gas) |
There was a problem hiding this comment.
is this gas limit or gas price? should be explicit
| var gasPrice = await GetGasPrice(); | ||
| var gasCost = gasLimit * gasPrice; | ||
|
|
||
| return new GasCosts { ether = gasPrice.ToString().ToEth(18, false), wei = gasCost }; |
| return new GasCosts { ether = gasPrice.ToString().ToEth(18, false), wei = gasCost }; | ||
| } | ||
|
|
||
| public async Task<Transaction> EstimateAndSetGasAsync() |
There was a problem hiding this comment.
If you manually change something like data/args or to generally do another estimation step. Might introduce a min limit default 100k in this function too? I'll also use it for my typed transactions later.
| return this; | ||
| } | ||
|
|
||
| public async Task<string> Send(bool? gasless = null) |
| req.uploadHandler = (UploadHandler)new UploadHandlerRaw(bodyRaw); | ||
| req.downloadHandler = (DownloadHandler)new DownloadHandlerBuffer(); | ||
| req.SetRequestHeader("Content-Type", "application/json"); | ||
| await req.SendWebRequest(); |
There was a problem hiding this comment.
the gasless code is re-used with the transaction manager no? might be useful to consolidate
There was a problem hiding this comment.
Will likely be moving the execution steps from TransactionManager to Transaction later, also contains some differences atm.
|
@joaquim-verges would appreciate another review while I do the WebGL side <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactoooooooooooooor