Skip to content

Conversation

arein
Copy link
Contributor

@arein arein commented Oct 9, 2025

Description

web3onboard makes use of WalletConnect requiredNamespaces which breaks some use cases and customers e.g. Safe{Wallet}. Newer versions of WalletConnect translate requiredNamespaces automatically into optionalNamespaces. I've decided to upgrade the WalletConnect dependency to latest instead of removing the use of requiredNamespaces as there are many other improvements in the more recent versions of the WalletConnect adapter.

Screenshot 2025-10-09 at 9 40 05 AM

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Summary by CodeRabbit

  • Chores

    • Bumped walletconnect package version to 2.6.3.
  • Dependencies

    • Updated WalletConnect Ethereum provider and related types to newer minor versions for improved stability and compatibility.
  • Bug Fixes

    • Incorporates upstream fixes from dependency updates, reducing potential connection and reliability issues.
  • Notes

    • No functional changes expected for end-users; updates focus on underlying reliability and compatibility improvements.

Copy link

coderabbitai bot commented Oct 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Version bumped for the walletconnect package and updates to one runtime dependency and one devDependency in package.json. No code or API surface changes.

Changes

Cohort / File(s) Summary
Version and dependencies update
packages/walletconnect/package.json
Bump package version 2.6.2 → 2.6.3; update dependency @walletconnect/ethereum-provider ^2.17.3 → ^2.21.10; update devDependency @walletconnect/types ^2.17.3 → ^2.21.10

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly identifies the primary change as upgrading WalletConnect dependencies, matching the core updates in the changeset without extra noise or ambiguity. It clearly communicates the main purpose of the PR to reviewers.
Description Check ✅ Passed The pull request description adheres to the repository’s template by providing a clear Description section with rationale and screenshot, followed by the required Checklist and Docs Checklist sections and the demo tests instructions; all required headings are present and the core information is detailed even though some optional checkboxes remain unchecked.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ee6a997 and 507ce66.

📒 Files selected for processing (1)
  • packages/walletconnect/package.json (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joaquim-verges joaquim-verges merged commit e3b8623 into thirdweb-dev:develop Oct 9, 2025
2 of 3 checks passed
joaquim-verges added a commit that referenced this pull request Oct 9, 2025
* Setting up GitHub CI for packages

* Pin github ci version

* update node version for all packages (#2367)

* update node version for all packages

* update

* chore: optimize onekey logo (#2369)

* fix: revert @web3-onboard/para in docs to 1.0.0 (#2372)

* fix: revert @web3-onboard/para in docs to 1.0.0

* add missing thirdweb icon

* Chore: update git pages action (#2375)

* fix: revert @web3-onboard/para in docs to 1.0.0

* chore: update git pages

* remove auto trigger

* rename blocknative URLs to thirdweb

* chore: git action to push to main + docs (#2378)

* chore: git action to push to main + docs

* lint

* chore: fix footer size/colors (#2379)

* chore: fix footer size/colors

* remove push to prod action

* chore: remove blocknative links from header (#2381)

* chore: upgrade WalletConnect dependencies (#2385)

* chore: upgrade WalletConnect dependencies

* chore: upgrade version

* bump version

---------

Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>

---------

Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com>
Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
Co-authored-by: Phillip Ho <arcoraven@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants