Render tokenId for erc1155 #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsdls
requested changes
Sep 26, 2022
Comment on lines
24
to
+31
| export const ClaimPage: React.FC<React.PropsWithChildren<ClaimPageProps>> = ({ | ||
| contract, | ||
|
|
||
| tokenId, | ||
| children, | ||
| }) => { | ||
| const { data: metadata, isLoading } = useContractMetadata(contract); | ||
| const { data: nft } = useNFT(contract, tokenId); | ||
|
|
There was a problem hiding this comment.
I would like to split this into 2 again now, TokenClaimPage (with the token) and ContractClaimPage (without the token)
we shouldn't even hav useNFT in the contract claim page case and we might not need contract metadata in the token claim page case? might just want to render token name and description instead?
Comment on lines
+45
to
+48
| {tokenId && nft?.metadata ? ( | ||
| <ThirdwebNftMedia metadata={nft.metadata} /> | ||
| ) : metadata?.image ? ( | ||
| <ThirdwebNftMedia metadata={metadata} /> |
There was a problem hiding this comment.
yeah ideally we split these high level into 2 components, one for erc20 and erc721 and one for erc1155
|
Superseded by #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.