-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade anchor-markdown-header
to fix emoji-titled headers
#232
Conversation
345ac5f
to
418cfcc
Compare
Hi great work @kevin-david on reproducing this in a test. |
Hey @thlorenz this should be fixed by my previous change in thlorenz/anchor-markdown-header#45 - I'm actually using my private fork at the moment, but I would love to clean that up! We just need a new release of https://www.npmjs.com/package/anchor-markdown-header with that change so I can consume it here, is that something you can do? Happy to update this PR to non-draft mode once that's done (with this test now passing) |
cf75d4d
to
6460f13
Compare
@thlorenz ready to go now with https://github.com/thlorenz/anchor-markdown-header's |
anchor-markdown-header
to fix emoji-titled headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the vscode config file LGTM, so please just remove and we can merge.
I'm making you contrib so you can do this yourself once you fix that nit.
This provides an example of the problem described in thlorenz#191.
6460f13
to
c817400
Compare
Thanks, is this ready to be published to npm? |
I think so, I've been testing this for a while with my fork and haven't seen any issues! |
OK went out as |
Just for the record, I did publish but forgot to check in the version change or tag it. So we just need to be aware the next time we publish a version as Sorry about that. |
Add test for emoji-titled headers
This provides an example of the problem described in #191.
### Add launch.json to enable test debuggingFor codespaces/VS Code. This was very helpful in diagnosing #191.Based on approach taken in https://stackoverflow.com/a/39607924, though the port stuff wasn't necessary anymore.Upgrade anchor-markdown-header to fix emoji-titled headers
Actually fixes #191