fix: formatted headers #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, we'll discuss details in the anchor markdown header PR since here we'll just have to bump the version once we figured it out. |
|
Thanks for merging, could you publish a release so we can use this? |
flexibrah
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really appreciate this package!
Running into this problem. Currently, headers like
# foo _bar_are transformed into this TOC entry:
But the actual anchor generated by GitHub is
foo-barand the TOC links break. Here's a sampleI've added a test to demonstrate this, not quite sure where to start fixing this. I ended up in theextractTextfunction, however now I'm thinking maybe this should be fixed in https://github.com/thlorenz/anchor-markdown-header?Any help is appreciated.EDIT This is now addressed with thlorenz/anchor-markdown-header#48. If that lands I will update this PR.