Corrects LDAP option bug by retrieving the constant value. #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldap_set_option expects an integer value to be provided for the option. This change properly looked up the integer value based on the name of the constant being passed.
|
Is it possible to add this to the 2.9 branch? |
|
It should be fine on 2.9 as well. I'm running the change on both our lab trunk install and our prod 2.9 RC4 install without issue. |
thorsten
added a commit
that referenced
this pull request
Apr 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldap_set_option expects an integer value to be provided for the option.
This change properly looked up the integer value based on the name of
the constant being passed.