Replace default value in url by placeholder #1330
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current browser display a warning if no valid url is entered into the url field of a form. Here this happens as well if create a news entry, but do not specify an url at all. This is avoided by using the "placeholder" attribute instead of the "value" attribute.
thorsten
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current browsers display a warning if no valid url is entered into an url field of a form.
On the "Add News" page this happens as well if create a news entry, but do not (want to) specify an url at all.
You have to deleted the "http://" manually before it is possible to save the news entry.
This could be avoided by using the "placeholder" attribute instead of the "value" attribute.
This way, the desired format is shown, but the user is not forced to take any action if no url is desired.