2.6 Email fixes #139
Merged
2.6 Email fixes #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 7, 2011 10:30
… entities in the plain-text emails.
…t names in sent emails, and prevent email header injection attacks using the Ask a question username field when mb_encode_mimeheader is not available.
…stion and comment email notifications to make it clearer what the emails are about.
|
Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thorsten,
I've made a few bug fixes and a small enhancement to the email notification code for new questions and comments, which I hope are useful to people.
Mainly this was to fix the irritation of characters such as quotes or ampersands showing up as html entities in the sent emails, but I've also improved the way special characters are handled in from, to, reply-to, etc headers in emails (and fixed a vulnerability) which I discovered during testing. I've also made the email subject lines distinct for comments and questions to make them more useful.
I made the changes against the 2.6 branch, as only my production install can send emails.
I'm new to both GitHub and git (but not version control generally), so my apologies if I've got this all wrong - please do point out the way I should have done things!
Regards,
Matt