Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 Email fixes #139

Merged
merged 4 commits into from Aug 8, 2011

Conversation

Projects
None yet
2 participants
@ribbons
Copy link

commented Aug 7, 2011

Hi Thorsten,

I've made a few bug fixes and a small enhancement to the email notification code for new questions and comments, which I hope are useful to people.

Mainly this was to fix the irritation of characters such as quotes or ampersands showing up as html entities in the sent emails, but I've also improved the way special characters are handled in from, to, reply-to, etc headers in emails (and fixed a vulnerability) which I discovered during testing. I've also made the email subject lines distinct for comments and questions to make them more useful.

I made the changes against the 2.6 branch, as only my production install can send emails.

I'm new to both GitHub and git (but not version control generally), so my apologies if I've got this all wrong - please do point out the way I should have done things!

Regards,

Matt

Matthew Robinson added some commits Aug 7, 2011

Matthew Robinson
Fix issues with quotes or commas breaking displayed sender / recipien…
…t names in sent emails, and prevent email header injection attacks using the Ask a question username field when mb_encode_mimeheader is not available.
Matthew Robinson
Append ' Question' and ' Comment' to the subject lines of the new que…
…stion and comment email notifications to make it clearer what the emails are about.

thorsten added a commit that referenced this pull request Aug 8, 2011

@thorsten thorsten merged commit 7ea4b2d into thorsten:2.6 Aug 8, 2011

@thorsten

This comment has been minimized.

Copy link
Owner

commented Aug 8, 2011

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.