Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DPR (Device Pixel Ratio) option #14

Closed
hermet opened this issue May 24, 2024 · 0 comments
Closed

Support DPR (Device Pixel Ratio) option #14

hermet opened this issue May 24, 2024 · 0 comments
Assignees
@tinyjin
Labels
feature New feature additions

Comments

@hermet
Copy link
Member

hermet commented May 24, 2024

The current thorvg player isn't scalable at browser scale factors. We should consider multiplying the DPR (Device Pixel Ratio) by the canvas size. See: https://cloudinary.com/glossary/device-pixel-ratio

See also: #8
@hermet hermet added the feature New feature additions label May 24, 2024
@hermet hermet mentioned this issue May 24, 2024
Closed
@tinyjin tinyjin self-assigned this Jun 23, 2024
tinyjin added a commit that referenced this issue Jun 23, 2024
@tinyjin
lottie: Support Device Pixel Ratio
8c48d92 
Support DPR scaling as a browser scale factor.

Issue: #14
@tinyjin tinyjin mentioned this issue Jun 23, 2024
Merged
hermet pushed a commit that referenced this issue Jul 5, 2024
@tinyjin @hermet
lottie: Support Device Pixel Ratio
37f06d6 
Support DPR scaling as a browser scale factor.

Issue: #14
@hermet hermet closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinyjin tinyjin

Labels
feature New feature additions
Projects
ThorVG.Web
Status: Done 0.15
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hermet @tinyjin