Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend the image to be used with a software stack without providing runtime environment #1943

Open
Tracked by #229
pacospace opened this issue Jun 23, 2021 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pacospace
Copy link
Contributor

pacospace commented Jun 23, 2021

Is your feature request related to a problem? Please describe.
As Data Scientist,

I want to build an AI pipeline where all my steps have different software stacks and runtime environments. Currently I have to choose runtime environment, but I don't know what is best for my software stack (best might be performance or latest for example).

The question I have is:

Can I receive the recommendation on the runtime to be used for a certain software stack (beside the software stack), so that I know the base image to use for building an image to use in the steps of my AI Pipeline?

Describe the solution you'd like
Have a recommendation when a runtime environment is not in input.

Describe alternatives you've considered
For steps that do not require performance in particular, just use a runtime environment I have. Submit different requests to thoth with same software stack, different runtime environments known to thoth, with performance recomendation type, and select the one that gives the highest score?

Additional context
Related-To: thoth-station/jupyterlab-requirements#229

@pacospace pacospace added kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it. labels Jun 23, 2021
@pacospace pacospace changed the title Suggest the image to be used with a software stack without providing runtime environment Recommend the image to be used with a software stack without providing runtime environment Jun 23, 2021
@fridex
Copy link
Contributor

fridex commented Jun 24, 2021

Is your feature request related to a problem? Please describe.
As Data Scientist,

I want to build an AI pipeline where all my steps have different software stacks and runtime environments. Currently I have to choose runtime environment, but I don't know what is best for my software stack (best might be performance or latest for example).

The question I have is:

Can I receive the recommendation on the runtime to be used for a certain software stack (beside the software stack), so that I know the base image to use for building an image to use in the steps of my AI Pipeline?

We can prioritize #1926 for this. In that case, we could have a look at the requirements a Thoth user uses and we will try to match them with container image analysis of Thoth s2i images. In that case, we will just check which s2i/jupyter notebook/... image uses a superset of Python packages that the user wants and we can recommend the base image for them (also considering other things like python version a user is running).

Describe alternatives you've considered
For steps that do not require performance in particular, just use a runtime environment I have. Submit different requests to thoth with same software stack, different runtime environments known to thoth, with performance recomendation type, and select the one that gives the highest score?

This is something the system could do on its own - #1533 - basically, if a request has no runtime environment specified, it can trigger multiple advisers with different runtime environments and see which runtime environment wins.

@goern
Copy link
Member

goern commented Jul 16, 2021

@pacospace what is the next step here?

@pacospace
Copy link
Contributor Author

@pacospace what is the next step here?

That we take the recommendation from adviser and automatically populate the thoth.yaml so that AICOE CI uses the correct base image when building images for AI Pipelines: thoth-station/jupyterlab-requirements#345

@sesheta
Copy link
Member

sesheta commented Aug 24, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 24, 2021
@fridex
Copy link
Contributor

fridex commented Aug 25, 2021

/remove-lifecycle rotten
/triage accepted

@sesheta sesheta added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 25, 2021
@sesheta
Copy link
Member

sesheta commented Sep 24, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta
Copy link
Member

sesheta commented Sep 24, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 24, 2021
@sesheta sesheta closed this as completed Sep 24, 2021
@sesheta
Copy link
Member

sesheta commented Sep 24, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacospace pacospace reopened this Sep 27, 2021
@pacospace pacospace added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. triage/needs-information Indicates an issue needs more information in order to work on it. labels Oct 6, 2021
@harshad16 harshad16 moved this to 🆕 New in Planning Board Oct 7, 2022
@codificat
Copy link
Member

/sig stack-guidance

@sesheta sesheta added the sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. label Jan 30, 2023
@goern goern removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants