Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure inclusion of a pipeline unit based on authentication #2103

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Sep 21, 2021

Related Issues and Dependencies

Fixes: #2096

This introduces a breaking change

  • No

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 21, 2021
@fridex
Copy link
Contributor Author

fridex commented Sep 22, 2021

/assign @meile18 @KPostOffice

Copy link

@meile18 meile18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@fridex
Copy link
Contributor Author

fridex commented Sep 22, 2021

lgtm

Thanks for the review 👍🏻

/approve

@sesheta
Copy link
Member

sesheta commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, meile18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@sesheta sesheta merged commit a3494be into thoth-station:master Sep 22, 2021
@fridex fridex deleted the should-include-authenticated branch September 22, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow matching pipeline units only for authenticated requests
4 participants