Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph refresh cronjob #35

Closed
wants to merge 1 commit into from

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Apr 23, 2018

No description provided.

@sesheta
Copy link
Member

sesheta commented Apr 23, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2018
@goern
Copy link
Member

goern commented Apr 23, 2018

@fridex
Copy link
Contributor Author

fridex commented Apr 23, 2018

hmm :) https://github.com/thoth-station/graph-refresh-job/blob/master/openshift/cronJob-template.yaml ?

All the other cronjobs (graph sync and cleanup job) live in the core deployment. Any particular reason why we should treat the refresh job differently?

@goern
Copy link
Member

goern commented Apr 23, 2018

I think we should keep all the things related to a service/job in it's own repo, core repo should deploy them all via ansible. Consequently we need to move cronobs from core to other repos.

I created #38

@fridex
Copy link
Contributor Author

fridex commented Apr 23, 2018

I think we should keep all the things related to a service/job in it's own repo, core repo should deploy them all via ansible. Consequently we need to move cronobs from core to other repos.

Ack, let's consolidate it.

@fridex fridex closed this Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants