Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pipfile lock #365

Merged
merged 3 commits into from
Jan 20, 2023
Merged

update pipfile lock #365

merged 3 commits into from
Jan 20, 2023

Conversation

goern
Copy link
Member

@goern goern commented Jan 20, 2023

  • ⬆️ manually update Pipfile.lock, related to cant run ./app.py #363
  • ⬆️ update pre-commit hooks
  • 🎉 thanks for all the work

@goern goern requested a review from harshad16 January 20, 2023 08:26
@sesheta sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 20, 2023
@goern goern mentioned this pull request Jan 20, 2023
Closed
harshad16
harshad16 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

👍

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@sesheta
Copy link
Member

sesheta commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@harshad16
Copy link
Member

Requires an rebase

@harshad16
Copy link
Member

Requires a rebase

@goern goern self-assigned this Jan 20, 2023
@goern goern removed the request for review from mayaCostantini January 20, 2023 15:19
@goern
⬆️ manually update Pipfile.lock, related to thoth-station#363
e9c6b54 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern
⬆️ update pre-commit hooks
f7ceacc 
Signed-off-by: Christoph Görn <goern@redhat.com>
@goern
🎉 thanks for all the work
041ab9e 
Signed-off-by: Christoph Görn <goern@redhat.com>
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 20, 2023
@harshad16
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@sesheta sesheta merged commit 6d7c641 into thoth-station:main Jan 20, 2023
@harshad16 harshad16 mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees

@goern goern

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goern @sesheta @harshad16