Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: Kebechet was picking approvers from it's own OWNERS file #1081

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Issue: Kebechet was picking approvers from it's own OWNERS file #1081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions kebechet/managers/thoth_advise/thoth_advise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,7 @@ def _act_on_advise_error(self, adv_results: dict):

def _get_users_with_permission(self) -> typing.List[str]:
try:
harshad16 marked this conversation as resolved.
Show resolved Hide resolved
with open("OWNERS", "r") as owners_file:
owners = yaml.safe_load(owners_file)
owners = yaml.safe_load(self.project.get_file_content("OWNERS"))
permitted_users = list(map(str, owners.get("approvers") or [])) + [APP_NAME]
except FileNotFoundError:
permitted_users = list(self.project.who_can_merge_pr()) + [APP_NAME]
Expand Down