Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment details in PR body #1120

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Add environment details in PR body #1120

merged 1 commit into from
Sep 2, 2022

Conversation

shreekarSS
Copy link
Member

Signed-off-by: Shreekara sshreeka@redhat.com

Related Issues and Dependencies

Fixes: #1099
…

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2022
@KPostOffice
Copy link
Member

What do you think about adding the env details to the body in this function and removing the code in other bodies? This way all PRs will have the env info.

kebechet/kebechet/managers/manager.py

Line 164 in c864a6b

body=body,

@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2022
@shreekarSS shreekarSS force-pushed the report_kebechet_version branch 2 times, most recently from b8b8860 to 5ed1c75 Compare September 1, 2022 13:25
KPostOffice
KPostOffice reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@KPostOffice KPostOffice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. What do you think about extending this for issues created by Kebechet as well?

kebechet/managers/manager.py Outdated
@@ -161,7 +161,7 @@ def create_pr(self, title: str, body: str, source_branch: str, target_branch: st
"""Create a PR but defaults to opening PR within a fork rather than on parent fork."""
return self.project.create_pr(
title=title,
body=body,
body=body + "\n" + str(self.get_environment_details()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap this in a <details> tag so that it is collapsable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

kebechet/managers/update/update.py
@@ -400,7 +399,7 @@ def _open_merge_request_update(
)

_LOGGER.info("Creating a new pull request to update dependencies.")
merge_request = self.project.create_pr(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another call in managers/version/version.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@shreekarSS shreekarSS force-pushed the report_kebechet_version branch 2 times, most recently from 8aa2f1e to aa088f7 Compare September 1, 2022 20:19
@shreekarSS
- Add environment details in PR body with <details> tag
c672a3e 
- Update UPDATE_MESSAGE_BODY to remove kebechet's version variable

- Update _generate_update_body to remove kebechet's version

- Update _create_pr_for_trigger_release() to call create_pr method
  wrapper

Signed-off-by: Shreekara <sshreeka@redhat.com>
@sesheta
Copy link
Member

sesheta commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@sesheta sesheta merged commit 30e76d2 into thoth-station:master Sep 2, 2022
@goern
Copy link
Member

goern commented Sep 5, 2022

@shreekarSS has this feature been released and deployed?

@harshad16 harshad16 mentioned this pull request Sep 13, 2022
Closed
@harshad16 harshad16 mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kebechet to report it's version on the PR body it creates
4 participants
@shreekarSS @KPostOffice @sesheta @goern